Skip to content

W
wine-winehq
Commit 477bce38 authored by Mike McCormack's avatar Mike McCormack Committed by Alexandre Julliard
Browse files
Options

msi: Eliminate a fixed length buffer.

parent f8125a98
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 5 deletions
dlls/msi/action.c
View file @ 477bce38
...@@ -2849,10 +2849,8 @@ static UINT ACTION_RegisterTypeLibraries(MSIPACKAGE *package) ...@@ -2849,10 +2849,8 @@ static UINT ACTION_RegisterTypeLibraries(MSIPACKAGE *package)
static UINT ITERATE_CreateShortcuts(MSIRECORD *row, LPVOID param) static UINT ITERATE_CreateShortcuts(MSIRECORD *row, LPVOID param)
{ {
MSIPACKAGE *package = (MSIPACKAGE*)param; MSIPACKAGE *package = (MSIPACKAGE*)param;
LPWSTR target_file, target_folder; LPWSTR target_file, target_folder, filename;
LPCWSTR buffer; LPCWSTR buffer;
WCHAR filename[0x100];
DWORD sz;
MSICOMPONENT *comp; MSICOMPONENT *comp;
static const WCHAR szlnk[]={'.','l','n','k',0}; static const WCHAR szlnk[]={'.','l','n','k',0};
IShellLinkW *sl; IShellLinkW *sl;
...@@ -2899,13 +2897,13 @@ static UINT ITERATE_CreateShortcuts(MSIRECORD *row, LPVOID param) ...@@ -2899,13 +2897,13 @@ static UINT ITERATE_CreateShortcuts(MSIRECORD *row, LPVOID param)
/* may be needed because of a bug somehwere else */ /* may be needed because of a bug somehwere else */
create_full_pathW(target_folder); create_full_pathW(target_folder);
sz = 0x100; filename = msi_dup_record_field( row, 3 );
MSI_RecordGetStringW(row,3,filename,&sz);
reduce_to_longfilename(filename); reduce_to_longfilename(filename);
if (!strchrW(filename,'.') || strcmpiW(strchrW(filename,'.'),szlnk)) if (!strchrW(filename,'.') || strcmpiW(strchrW(filename,'.'),szlnk))
strcatW(filename,szlnk); strcatW(filename,szlnk);
target_file = build_directory_name(2, target_folder, filename); target_file = build_directory_name(2, target_folder, filename);
msi_free(target_folder); msi_free(target_folder);
msi_free(filename);
buffer = MSI_RecordGetString(row,5); buffer = MSI_RecordGetString(row,5);
if (strchrW(buffer,'[')) if (strchrW(buffer,'['))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment