Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
4a0901fb
Commit
4a0901fb
authored
May 29, 2009
by
Vincent Povirk
Committed by
Alexandre Julliard
Jun 01, 2009
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ole32: Fix crash when calling CreateStream on read only storage.
parent
5aab52c9
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
2 deletions
+4
-2
storage32.c
dlls/ole32/storage32.c
+4
-0
storage32.c
dlls/ole32/tests/storage32.c
+0
-2
No files found.
dlls/ole32/storage32.c
View file @
4a0901fb
...
...
@@ -979,6 +979,10 @@ static HRESULT WINAPI StorageBaseImpl_CreateStream(
(
grfMode
&
STGM_TRANSACTED
))
return
STG_E_INVALIDFUNCTION
;
/* Can't create a stream on read-only storage */
if
(
STGM_ACCESS_MODE
(
This
->
openFlags
)
==
STGM_READ
)
return
STG_E_ACCESSDENIED
;
/*
* Check that we're compatible with the parent's storage mode
* if not in transacted mode
...
...
dlls/ole32/tests/storage32.c
View file @
4a0901fb
...
...
@@ -1302,13 +1302,11 @@ void test_readonly(void)
ok
(
hr
==
S_OK
,
"should succeed, res=%x
\n
"
,
hr
);
if
(
SUCCEEDED
(
hr
))
{
#if 0 /* crashes on Wine */
/* CreateStream on read-only storage, name exists */
hr
=
IStorage_CreateStream
(
stg2
,
streamW
,
STGM_CREATE
|
STGM_SHARE_EXCLUSIVE
|
STGM_READ
,
0
,
0
,
&
stream
);
ok
(
hr
==
STG_E_ACCESSDENIED
,
"should fail, res=%x
\n
"
,
hr
);
if
(
SUCCEEDED
(
hr
))
IStream_Release
(
stream
);
#endif
/* CreateStream on read-only storage, name does not exist */
hr
=
IStorage_CreateStream
(
stg2
,
storageW
,
STGM_CREATE
|
STGM_SHARE_EXCLUSIVE
|
STGM_READ
,
0
,
0
,
&
stream
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment