qedit: Remove the splitter from the graph if it failed to connect.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com> Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

qedit: Remove the splitter from the graph if it failed to connect.
4d94e773 · Gabriel Ivăncescu · Alexandre Julliard · 2e6f5e67 · 4d94e773
Commit 4d94e773 authored Apr 23, 2020 by Gabriel Ivăncescu Committed by Alexandre Julliard Apr 24, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 8 deletions

mediadet.c dlls/qedit/mediadet.c +5 -8

No files found.
--- a/dlls/qedit/mediadet.c
+++ b/dlls/qedit/mediadet.c
@@ -193,17 +193,12 @@ static HRESULT find_splitter(MediaDetImpl *detector)

        hr = IBaseFilter_EnumPins(splitter, &enum_pins);
        if (FAILED(hr))
-        {
-            IBaseFilter_Release(splitter);
-            continue;
-        }
+            goto next;
+
        hr = IEnumPins_Next(enum_pins, 1, &splitter_pin, NULL);
        IEnumPins_Release(enum_pins);
        if (FAILED(hr))
-        {
-            IBaseFilter_Release(splitter);
-            continue;
-        }
+            goto next;

        hr = IPin_Connect(source_pin, splitter_pin, NULL);
        IPin_Release(splitter_pin);
@@ -213,6 +208,8 @@ static HRESULT find_splitter(MediaDetImpl *detector)
            break;
        }

+next:
+        IGraphBuilder_RemoveFilter(detector->graph, splitter);
        IBaseFilter_Release(splitter);
    }