mshtml: Fix use after free in use_gecko_script (Coverity).

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com> Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mshtml: Fix use after free in use_gecko_script (Coverity).
4ef2557d · Alex Henrie · Alexandre Julliard · 45b9dccb · 4ef2557d
Commit 4ef2557d authored Dec 29, 2021 by Alex Henrie Committed by Alexandre Julliard Dec 30, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

script.c dlls/mshtml/script.c +2 -1

No files found.
--- a/dlls/mshtml/script.c
+++ b/dlls/mshtml/script.c
@@ -1716,12 +1716,13 @@ static BOOL use_gecko_script(IUri *uri)
        return FALSE;

    hres = IInternetSecurityManager_MapUrlToZone(get_security_manager(), display_uri, &zone, 0);
-    SysFreeString(display_uri);
    if(FAILED(hres)) {
        WARN("Could not map %s to zone: %08x\n", debugstr_w(display_uri), hres);
+        SysFreeString(display_uri);
        return TRUE;
    }

+    SysFreeString(display_uri);
    TRACE("zone %d\n", zone);
    return zone == URLZONE_UNTRUSTED;
 }