msxml3: Fix uri object leak on error path (Valgrind).

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msxml3: Fix uri object leak on error path (Valgrind).
5825ad56 · Nikolay Sivov · Alexandre Julliard · 36588028 · 5825ad56
Commit 5825ad56 authored Dec 17, 2018 by Nikolay Sivov Committed by Alexandre Julliard Dec 17, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 4 deletions

domdoc.c dlls/msxml3/domdoc.c +8 -4

No files found.
--- a/dlls/msxml3/domdoc.c
+++ b/dlls/msxml3/domdoc.c
@@ -2292,8 +2292,8 @@ static HRESULT WINAPI domdoc_load(

    if ( filename )
    {
+        IUri *uri = NULL;
        IMoniker *mon;
-        IUri *uri;

        if (This->properties->uri)
        {
@@ -2310,15 +2310,19 @@ static HRESULT WINAPI domdoc_load(
            IMoniker_Release(mon);
        }

-        if ( FAILED(hr) )
-            This->error = E_FAIL;
-        else
+        if (SUCCEEDED(hr))
        {
            get_doc(This)->name = (char *)xmlchar_from_wcharn(filename, -1, TRUE);
            This->properties->uri = uri;
            hr = This->error = S_OK;
            *isSuccessful = VARIANT_TRUE;
        }
+        else
+        {
+            if (uri)
+                IUri_Release(uri);
+            This->error = E_FAIL;
+        }
    }

    if(!filename || FAILED(hr)) {