winspool: Fix memory leaks on error path in DeviceCapabilitiesA (Coverity).

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com> Signed-off-by: Huw Davies <huw@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

winspool: Fix memory leaks on error path in DeviceCapabilitiesA (Coverity).
5a12c6a4 · Alex Henrie · Alexandre Julliard · 746b5bbd · 5a12c6a4
Commit 5a12c6a4 authored Feb 02, 2022 by Alex Henrie Committed by Alexandre Julliard Feb 03, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

info.c dlls/winspool.drv/info.c +2 -1

No files found.
--- a/dlls/winspool.drv/info.c
+++ b/dlls/winspool.drv/info.c
@@ -1775,7 +1775,7 @@ INT WINAPI DeviceCapabilitiesA(const char *device, const char *portA, WORD cap,
        WCHAR *outputW;

        ret = DeviceCapabilitiesW(device_name, port, cap, NULL, devmode);
-        if (ret == -1) return ret;
+        if (ret == -1) goto cleanup;

        switch (cap) {
        case DC_BINNAMES:
@@ -1795,6 +1795,7 @@ INT WINAPI DeviceCapabilitiesA(const char *device, const char *portA, WORD cap,
    } else {
        ret = DeviceCapabilitiesW(device_name, port, cap, (WCHAR *)output, devmode);
    }
+cleanup:
    HeapFree(GetProcessHeap(), 0, device_name);
    HeapFree(GetProcessHeap(), 0, devmode);
    HeapFree(GetProcessHeap(), 0, port);