Commit 5ea23d61 authored by Michael Stefaniuc's avatar Michael Stefaniuc Committed by Alexandre Julliard

shell32: Use FAILED instead of !SUCCEEDED.

parent 8b3f3ef8
...@@ -688,8 +688,7 @@ static HRESULT WINAPI ISF_ControlPanel_fnGetDisplayNameOf(IShellFolder2 * iface, ...@@ -688,8 +688,7 @@ static HRESULT WINAPI ISF_ControlPanel_fnGetDisplayNameOf(IShellFolder2 * iface,
PathAddBackslashW(wszPath); PathAddBackslashW(wszPath);
len = lstrlenW(wszPath); len = lstrlenW(wszPath);
if (!SUCCEEDED if (FAILED(SHELL32_GetDisplayNameOfChild(iface, pidl, dwFlags | SHGDN_INFOLDER, wszPath + len, MAX_PATH + 1 - len)))
(SHELL32_GetDisplayNameOfChild(iface, pidl, dwFlags | SHGDN_INFOLDER, wszPath + len, MAX_PATH + 1 - len)))
return E_OUTOFMEMORY; return E_OUTOFMEMORY;
if (!WideCharToMultiByte(CP_ACP, 0, wszPath, -1, szPath, MAX_PATH, NULL, NULL)) if (!WideCharToMultiByte(CP_ACP, 0, wszPath, -1, szPath, MAX_PATH, NULL, NULL))
wszPath[0] = '\0'; wszPath[0] = '\0';
......
...@@ -350,13 +350,13 @@ HRESULT WINAPI SHCreateShellItem(LPCITEMIDLIST pidlParent, ...@@ -350,13 +350,13 @@ HRESULT WINAPI SHCreateShellItem(LPCITEMIDLIST pidlParent,
{ {
IPersistFolder2* ppf2Parent; IPersistFolder2* ppf2Parent;
if (!SUCCEEDED(IPersistFolder2_QueryInterface(psfParent, &IID_IPersistFolder2, (void**)&ppf2Parent))) if (FAILED(IPersistFolder2_QueryInterface(psfParent, &IID_IPersistFolder2, (void**)&ppf2Parent)))
{ {
FIXME("couldn't get IPersistFolder2 interface of parent\n"); FIXME("couldn't get IPersistFolder2 interface of parent\n");
return E_NOINTERFACE; return E_NOINTERFACE;
} }
if (!SUCCEEDED(IPersistFolder2_GetCurFolder(ppf2Parent, &temp_parent))) if (FAILED(IPersistFolder2_GetCurFolder(ppf2Parent, &temp_parent)))
{ {
FIXME("couldn't get parent PIDL\n"); FIXME("couldn't get parent PIDL\n");
IPersistFolder2_Release(ppf2Parent); IPersistFolder2_Release(ppf2Parent);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment