reg: Prevent buffer over-read when querying REG_NONE values with no data.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

reg: Prevent buffer over-read when querying REG_NONE values with no data.
60c8dfdd · Hugh McMaster · Alexandre Julliard · 1dd785d1 · 60c8dfdd
Commit 60c8dfdd authored May 06, 2021 by Hugh McMaster Committed by Alexandre Julliard May 06, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

query.c programs/reg/query.c +8 -0

No files found.
--- a/programs/reg/query.c
+++ b/programs/reg/query.c
@@ -50,7 +50,15 @@ static WCHAR *reg_data_to_wchar(DWORD type, const BYTE *src, DWORD size_bytes)
            WCHAR *ptr;

            buffer = malloc((size_bytes * 2 + 1) * sizeof(WCHAR));
+
+            if (!size_bytes)
+            {
+                *buffer = 0;
+                break;
+            }
+
            ptr = buffer;
+
            for (i = 0; i < size_bytes; i++)
                ptr += swprintf(ptr, 3, L"%02X", src[i]);
            break;