Commit 66eca8b3 authored by Piotr Caban's avatar Piotr Caban Committed by Alexandre Julliard

msxml3/tests: Better error messages formatting.

parent 1be44ab2
...@@ -101,18 +101,18 @@ static void test_xmldoc(void) ...@@ -101,18 +101,18 @@ static void test_xmldoc(void)
ok(file_size == read, "Expected to read the whole file, read %d\n", read); ok(file_size == read, "Expected to read the whole file, read %d\n", read);
hr = CreateStreamOnHGlobal(hglobal, TRUE, &stream); hr = CreateStreamOnHGlobal(hglobal, TRUE, &stream);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(stream != NULL, "Expected non-NULL stream\n"); ok(stream != NULL, "Expected non-NULL stream\n");
CloseHandle(hfile); CloseHandle(hfile);
GlobalUnlock(hglobal); GlobalUnlock(hglobal);
hr = IXMLDocument_QueryInterface(doc, &IID_IPersistStreamInit, (LPVOID *)&psi); hr = IXMLDocument_QueryInterface(doc, &IID_IPersistStreamInit, (LPVOID *)&psi);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(psi != NULL, "Expected non-NULL psi\n"); ok(psi != NULL, "Expected non-NULL psi\n");
hr = IXMLDocument_get_root(doc, &element); hr = IXMLDocument_get_root(doc, &element);
ok(hr == E_FAIL, "Expected E_FAIL, got %d\n", hr); ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
ok(element == NULL, "Expected NULL element\n"); ok(element == NULL, "Expected NULL element\n");
hr = IPersistStreamInit_Load(psi, stream); hr = IPersistStreamInit_Load(psi, stream);
...@@ -123,24 +123,24 @@ static void test_xmldoc(void) ...@@ -123,24 +123,24 @@ static void test_xmldoc(void)
ok(stream != NULL, "Expected non-NULL stream\n"); ok(stream != NULL, "Expected non-NULL stream\n");
hr = IXMLDocument_get_root(doc, &element); hr = IXMLDocument_get_root(doc, &element);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(element != NULL, "Expected non-NULL element\n"); ok(element != NULL, "Expected non-NULL element\n");
hr = IXMLElement_get_type(element, &type); hr = IXMLElement_get_type(element, &type);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type); ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
hr = IXMLElement_get_tagName(element, &name); hr = IXMLElement_get_tagName(element, &name);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(!lstrcmpW(name, szBankAccount), "Expected BANKACCOUNT\n"); ok(!lstrcmpW(name, szBankAccount), "Expected BANKACCOUNT\n");
SysFreeString(name); SysFreeString(name);
hr = IXMLElement_get_children(element, &collection); hr = IXMLElement_get_children(element, &collection);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(collection != NULL, "Expected non-NULL collection\n"); ok(collection != NULL, "Expected non-NULL collection\n");
hr = IXMLElementCollection_get_length(collection, &num_child); hr = IXMLElementCollection_get_length(collection, &num_child);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(num_child == 2, "Expected 2, got %ld\n", num_child); ok(num_child == 2, "Expected 2, got %ld\n", num_child);
V_VT(&vIndex) = VT_I4; V_VT(&vIndex) = VT_I4;
...@@ -148,36 +148,36 @@ static void test_xmldoc(void) ...@@ -148,36 +148,36 @@ static void test_xmldoc(void)
V_VT(&vName) = VT_ERROR; V_VT(&vName) = VT_ERROR;
V_ERROR(&vName) = DISP_E_PARAMNOTFOUND; V_ERROR(&vName) = DISP_E_PARAMNOTFOUND;
hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child); hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(child != NULL, "Expected non-NULL child\n"); ok(child != NULL, "Expected non-NULL child\n");
hr = IXMLElement_get_type(child, &type); hr = IXMLElement_get_type(child, &type);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type); ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
hr = IXMLElement_get_tagName(child, &name); hr = IXMLElement_get_tagName(child, &name);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(!lstrcmpW(name, szNumber), "Expected NUMBER\n"); ok(!lstrcmpW(name, szNumber), "Expected NUMBER\n");
SysFreeString(name); SysFreeString(name);
hr = IXMLElement_get_children(child, &inner); hr = IXMLElement_get_children(child, &inner);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(inner != NULL, "Expected non-NULL inner\n"); ok(inner != NULL, "Expected non-NULL inner\n");
hr = IXMLElementCollection_get_length(inner, &num_child); hr = IXMLElementCollection_get_length(inner, &num_child);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(num_child == 1, "Expected 1, got %ld\n", num_child); ok(num_child == 1, "Expected 1, got %ld\n", num_child);
hr = IXMLElementCollection_item(inner, vIndex, vName, (IDispatch **)&value); hr = IXMLElementCollection_item(inner, vIndex, vName, (IDispatch **)&value);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(value != NULL, "Expected non-NULL value\n"); ok(value != NULL, "Expected non-NULL value\n");
hr = IXMLElement_get_type(value, &type); hr = IXMLElement_get_type(value, &type);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(type == XMLELEMTYPE_TEXT, "Expected XMLELEMTYPE_TEXT, got %ld\n", type); ok(type == XMLELEMTYPE_TEXT, "Expected XMLELEMTYPE_TEXT, got %ld\n", type);
hr = IXMLElement_get_text(value, &name); hr = IXMLElement_get_text(value, &name);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(!lstrcmpW(name, szNumVal), "Expected '1234'\n"); ok(!lstrcmpW(name, szNumVal), "Expected '1234'\n");
SysFreeString(name); SysFreeString(name);
...@@ -185,7 +185,7 @@ static void test_xmldoc(void) ...@@ -185,7 +185,7 @@ static void test_xmldoc(void)
inner = (IXMLElementCollection *)0xdeadbeef; inner = (IXMLElementCollection *)0xdeadbeef;
hr = IXMLElement_get_children(value, &inner); hr = IXMLElement_get_children(value, &inner);
ok(hr == 1, "Expected 1, got %d\n", hr); ok(hr == 1, "Expected 1, got %08x\n", hr);
ok(inner == NULL, "Expected NULL inner, got %p\n", inner); ok(inner == NULL, "Expected NULL inner, got %p\n", inner);
IXMLElement_Release(value); IXMLElement_Release(value);
...@@ -195,37 +195,37 @@ static void test_xmldoc(void) ...@@ -195,37 +195,37 @@ static void test_xmldoc(void)
V_I4(&vIndex) = 1; V_I4(&vIndex) = 1;
hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child); hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(child != NULL, "Expected non-NULL child\n"); ok(child != NULL, "Expected non-NULL child\n");
hr = IXMLElement_get_type(child, &type); hr = IXMLElement_get_type(child, &type);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type); ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
hr = IXMLElement_get_tagName(child, &name); hr = IXMLElement_get_tagName(child, &name);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(!lstrcmpW(name, szName), "Expected NAME\n"); ok(!lstrcmpW(name, szName), "Expected NAME\n");
SysFreeString(name); SysFreeString(name);
hr = IXMLElement_get_children(child, &inner); hr = IXMLElement_get_children(child, &inner);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(inner != NULL, "Expected non-NULL inner\n"); ok(inner != NULL, "Expected non-NULL inner\n");
hr = IXMLElementCollection_get_length(inner, &num_child); hr = IXMLElementCollection_get_length(inner, &num_child);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(num_child == 1, "Expected 1, got %ld\n", num_child); ok(num_child == 1, "Expected 1, got %ld\n", num_child);
V_I4(&vIndex) = 0; V_I4(&vIndex) = 0;
hr = IXMLElementCollection_item(inner, vIndex, vName, (IDispatch **)&value); hr = IXMLElementCollection_item(inner, vIndex, vName, (IDispatch **)&value);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(value != NULL, "Expected non-NULL value\n"); ok(value != NULL, "Expected non-NULL value\n");
hr = IXMLElement_get_type(value, &type); hr = IXMLElement_get_type(value, &type);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(type == XMLELEMTYPE_TEXT, "Expected XMLELEMTYPE_TEXT, got %ld\n", type); ok(type == XMLELEMTYPE_TEXT, "Expected XMLELEMTYPE_TEXT, got %ld\n", type);
hr = IXMLElement_get_text(value, &name); hr = IXMLElement_get_text(value, &name);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(!lstrcmpW(name, szNameVal), "Expected 'Captain Ahab'\n"); ok(!lstrcmpW(name, szNameVal), "Expected 'Captain Ahab'\n");
SysFreeString(name); SysFreeString(name);
...@@ -233,7 +233,7 @@ static void test_xmldoc(void) ...@@ -233,7 +233,7 @@ static void test_xmldoc(void)
inner = (IXMLElementCollection *)0xdeadbeef; inner = (IXMLElementCollection *)0xdeadbeef;
hr = IXMLElement_get_children(value, &inner); hr = IXMLElement_get_children(value, &inner);
ok(hr == 1, "Expected 1, got %d\n", hr); ok(hr == 1, "Expected 1, got %08x\n", hr);
ok(inner == NULL, "Expected NULL inner, got %p\n", inner); ok(inner == NULL, "Expected NULL inner, got %p\n", inner);
IXMLElement_Release(value); IXMLElement_Release(value);
...@@ -269,7 +269,7 @@ static void test_createElement(void) ...@@ -269,7 +269,7 @@ static void test_createElement(void)
V_VT(&vName) = VT_NULL; V_VT(&vName) = VT_NULL;
element = (IXMLElement *)0xdeadbeef; element = (IXMLElement *)0xdeadbeef;
hr = IXMLDocument_createElement(doc, vType, vName, &element); hr = IXMLDocument_createElement(doc, vType, vName, &element);
ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %d\n", hr); ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %08x\n", hr);
ok(element == NULL, "Expected NULL element\n"); ok(element == NULL, "Expected NULL element\n");
/* invalid vType value */ /* invalid vType value */
...@@ -284,7 +284,7 @@ static void test_createElement(void) ...@@ -284,7 +284,7 @@ static void test_createElement(void)
if (element != NULL) if (element != NULL)
{ {
hr = IXMLElement_get_type(element, &type); hr = IXMLElement_get_type(element, &type);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
/* SP7 returns an XMLELEMTYPE_ELEMENT */ /* SP7 returns an XMLELEMTYPE_ELEMENT */
ok(type == XMLELEMTYPE_OTHER || type == XMLELEMTYPE_ELEMENT, ok(type == XMLELEMTYPE_OTHER || type == XMLELEMTYPE_ELEMENT,
"Expected XMLELEMTYPE_OTHER || XMLELEMTYPE_ELEMENT, got %ld\n", type); "Expected XMLELEMTYPE_OTHER || XMLELEMTYPE_ELEMENT, got %ld\n", type);
...@@ -294,7 +294,7 @@ static void test_createElement(void) ...@@ -294,7 +294,7 @@ static void test_createElement(void)
} }
else else
{ {
ok(hr == E_NOTIMPL, "Expected E_NOTIMPL, got %d\n", hr); ok(hr == E_NOTIMPL, "Expected E_NOTIMPL, got %08x\n", hr);
ok(element == NULL, "Expected NULL element\n"); ok(element == NULL, "Expected NULL element\n");
} }
...@@ -303,11 +303,11 @@ static void test_createElement(void) ...@@ -303,11 +303,11 @@ static void test_createElement(void)
V_I4(&vType) = XMLELEMTYPE_ELEMENT; V_I4(&vType) = XMLELEMTYPE_ELEMENT;
V_VT(&vName) = VT_I4; V_VT(&vName) = VT_I4;
hr = IXMLDocument_createElement(doc, vType, vName, &element); hr = IXMLDocument_createElement(doc, vType, vName, &element);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(element != NULL, "Expected non-NULL element\n"); ok(element != NULL, "Expected non-NULL element\n");
hr = IXMLElement_get_type(element, &type); hr = IXMLElement_get_type(element, &type);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type); ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %ld\n", type);
IXMLElement_Release(element); IXMLElement_Release(element);
...@@ -328,13 +328,13 @@ static void test_createElement(void) ...@@ -328,13 +328,13 @@ static void test_createElement(void)
V_I4(&vType) = XMLELEMTYPE_ELEMENT; V_I4(&vType) = XMLELEMTYPE_ELEMENT;
V_VT(&vName) = VT_NULL; V_VT(&vName) = VT_NULL;
hr = IXMLDocument_createElement(doc, vType, vName, &element); hr = IXMLDocument_createElement(doc, vType, vName, &element);
ok(hr == S_OK, "Expected S_OK, got %d\n", hr); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr);
ok(element != NULL, "Expected non-NULL element\n"); ok(element != NULL, "Expected non-NULL element\n");
/* createElement does not set the new element as root */ /* createElement does not set the new element as root */
root = (IXMLElement *)0xdeadbeef; root = (IXMLElement *)0xdeadbeef;
hr = IXMLDocument_get_root(doc, &root); hr = IXMLDocument_get_root(doc, &root);
ok(hr == E_FAIL, "Expected E_FAIL, got %d\n", hr); ok(hr == E_FAIL, "Expected E_FAIL, got %08x\n", hr);
ok(root == NULL, "Expected NULL root\n"); ok(root == NULL, "Expected NULL root\n");
IXMLElement_Release(element); IXMLElement_Release(element);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment