quartz: Return E_INVALIDARG when cursor is NULL in IEnumFilters::Skip().

Signed-off-by: Gijs Vermeulen <gijsvrm@gmail.com> Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

quartz: Return E_INVALIDARG when cursor is NULL in IEnumFilters::Skip().
68d03ba8 · Gijs Vermeulen · Alexandre Julliard · d918c6a4 · 68d03ba8 · 68d03ba8
Commit 68d03ba8 authored Nov 23, 2020 by Gijs Vermeulen Committed by Alexandre Julliard Nov 23, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

filtergraph.c dlls/quartz/filtergraph.c +1 -1

filtergraph.c dlls/quartz/tests/filtergraph.c +6 -0

No files found.
--- a/dlls/quartz/filtergraph.c
+++ b/dlls/quartz/filtergraph.c
@@ -326,7 +326,7 @@ static HRESULT WINAPI EnumFilters_Skip(IEnumFilters *iface, ULONG count)
        return VFW_E_ENUM_OUT_OF_SYNC;

    if (!enum_filters->cursor)
-        return S_FALSE;
+        return E_INVALIDARG;

    while (count--)
    {

--- a/dlls/quartz/tests/filtergraph.c
+++ b/dlls/quartz/tests/filtergraph.c
@@ -677,6 +677,12 @@ static void test_enum_filters(void)
    hr = IEnumFilters_Next(enum1, 1, filters, NULL);
    ok(hr == S_FALSE, "Got hr %#x.\n", hr);

+    hr = IEnumFilters_Skip(enum1, 0);
+    ok(hr == E_INVALIDARG, "Got hr %#x.\n", hr);
+
+    hr = IEnumFilters_Skip(enum1, 1);
+    ok(hr == E_INVALIDARG, "Got hr %#x.\n", hr);
+
    IFilterGraph2_AddFilter(graph, filter1, NULL);
    IFilterGraph2_AddFilter(graph, filter2, NULL);