Commit 6ed1e5c2 authored by Zebediah Figura's avatar Zebediah Figura Committed by Alexandre Julliard

quartz/tests: Clean up and expand tests for aggregation.

parent 50395b03
...@@ -10,7 +10,6 @@ C_SRCS = \ ...@@ -10,7 +10,6 @@ C_SRCS = \
filtergraph.c \ filtergraph.c \
filtermapper.c \ filtermapper.c \
memallocator.c \ memallocator.c \
misc.c \
mpegsplit.c \ mpegsplit.c \
systemclock.c \ systemclock.c \
videorenderer.c \ videorenderer.c \
......
...@@ -78,6 +78,13 @@ static IFilterGraph2 *create_graph(void) ...@@ -78,6 +78,13 @@ static IFilterGraph2 *create_graph(void)
return ret; return ret;
} }
static ULONG get_refcount(void *iface)
{
IUnknown *unknown = iface;
IUnknown_AddRef(unknown);
return IUnknown_Release(unknown);
}
#define check_interface(a, b, c) check_interface_(__LINE__, a, b, c) #define check_interface(a, b, c) check_interface_(__LINE__, a, b, c)
static void check_interface_(unsigned int line, void *iface_ptr, REFIID iid, BOOL supported) static void check_interface_(unsigned int line, void *iface_ptr, REFIID iid, BOOL supported)
{ {
...@@ -2291,96 +2298,98 @@ out: ...@@ -2291,96 +2298,98 @@ out:
ok(parser3_pins[1].ref == 1, "Got outstanding refcount %d.\n", parser3_pins[1].ref); ok(parser3_pins[1].ref == 1, "Got outstanding refcount %d.\n", parser3_pins[1].ref);
} }
typedef struct IUnknownImpl static const GUID test_iid = {0x33333333};
{ static LONG outer_ref = 1;
IUnknown IUnknown_iface;
int AddRef_called;
int Release_called;
} IUnknownImpl;
static IUnknownImpl *IUnknownImpl_from_iface(IUnknown * iface)
{
return CONTAINING_RECORD(iface, IUnknownImpl, IUnknown_iface);
}
static HRESULT WINAPI IUnknownImpl_QueryInterface(IUnknown * iface, REFIID riid, LPVOID * ppv) static HRESULT WINAPI outer_QueryInterface(IUnknown *iface, REFIID iid, void **out)
{ {
ok(0, "QueryInterface should not be called for %s\n", wine_dbgstr_guid(riid)); if (IsEqualGUID(iid, &IID_IUnknown)
|| IsEqualGUID(iid, &IID_IFilterGraph2)
|| IsEqualGUID(iid, &test_iid))
{
*out = (IUnknown *)0xdeadbeef;
return S_OK;
}
ok(0, "unexpected call %s\n", wine_dbgstr_guid(iid));
return E_NOINTERFACE; return E_NOINTERFACE;
} }
static ULONG WINAPI IUnknownImpl_AddRef(IUnknown * iface) static ULONG WINAPI outer_AddRef(IUnknown *iface)
{ {
IUnknownImpl *This = IUnknownImpl_from_iface(iface); return InterlockedIncrement(&outer_ref);
This->AddRef_called++;
return 2;
} }
static ULONG WINAPI IUnknownImpl_Release(IUnknown * iface) static ULONG WINAPI outer_Release(IUnknown *iface)
{ {
IUnknownImpl *This = IUnknownImpl_from_iface(iface); return InterlockedDecrement(&outer_ref);
This->Release_called++;
return 1;
} }
static CONST_VTBL IUnknownVtbl IUnknownImpl_Vtbl = static const IUnknownVtbl outer_vtbl =
{ {
IUnknownImpl_QueryInterface, outer_QueryInterface,
IUnknownImpl_AddRef, outer_AddRef,
IUnknownImpl_Release outer_Release,
}; };
static void test_aggregate_filter_graph(void) static IUnknown test_outer = {&outer_vtbl};
static void test_aggregation(void)
{ {
IFilterGraph2 *graph, *graph2;
IUnknown *unk, *unk2;
HRESULT hr; HRESULT hr;
IUnknown *pgraph; ULONG ref;
IUnknown *punk;
IUnknownImpl unk_outer = { { &IUnknownImpl_Vtbl }, 0, 0 };
hr = CoCreateInstance(&CLSID_FilterGraph, &unk_outer.IUnknown_iface, CLSCTX_INPROC_SERVER, graph = (IFilterGraph2 *)0xdeadbeef;
&IID_IUnknown, (void **)&pgraph); hr = CoCreateInstance(&CLSID_FilterGraph, &test_outer, CLSCTX_INPROC_SERVER,
ok(hr == S_OK, "CoCreateInstance returned %x\n", hr); &IID_IFilterGraph2, (void **)&graph);
ok(pgraph != &unk_outer.IUnknown_iface, "pgraph = %p, expected not %p\n", pgraph, &unk_outer.IUnknown_iface); ok(hr == E_NOINTERFACE, "Got hr %#x.\n", hr);
ok(!graph, "Got interface %p.\n", graph);
hr = IUnknown_QueryInterface(pgraph, &IID_IUnknown, (void **)&punk); hr = CoCreateInstance(&CLSID_FilterGraph, &test_outer, CLSCTX_INPROC_SERVER,
ok(hr == S_OK, "CoCreateInstance returned %x\n", hr); &IID_IUnknown, (void **)&unk);
ok(punk != &unk_outer.IUnknown_iface, "punk = %p, expected not %p\n", punk, &unk_outer.IUnknown_iface); ok(hr == S_OK, "Got hr %#x.\n", hr);
IUnknown_Release(punk); ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
ok(unk != &test_outer, "Returned IUnknown should not be outer IUnknown.\n");
ref = get_refcount(unk);
ok(ref == 1, "Got unexpected refcount %d.\n", ref);
ok(unk_outer.AddRef_called == 0, "IUnknownImpl_AddRef called %d times\n", unk_outer.AddRef_called); ref = IUnknown_AddRef(unk);
ok(unk_outer.Release_called == 0, "IUnknownImpl_Release called %d times\n", unk_outer.Release_called); ok(ref == 2, "Got unexpected refcount %d.\n", ref);
unk_outer.AddRef_called = 0; ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
unk_outer.Release_called = 0;
hr = IUnknown_QueryInterface(pgraph, &IID_IFilterMapper, (void **)&punk); ref = IUnknown_Release(unk);
ok(hr == S_OK, "CoCreateInstance returned %x\n", hr); ok(ref == 1, "Got unexpected refcount %d.\n", ref);
ok(punk != &unk_outer.IUnknown_iface, "punk = %p, expected not %p\n", punk, &unk_outer.IUnknown_iface); ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
IUnknown_Release(punk);
ok(unk_outer.AddRef_called == 1, "IUnknownImpl_AddRef called %d times\n", unk_outer.AddRef_called); hr = IUnknown_QueryInterface(unk, &IID_IUnknown, (void **)&unk2);
ok(unk_outer.Release_called == 1, "IUnknownImpl_Release called %d times\n", unk_outer.Release_called); ok(hr == S_OK, "Got hr %#x.\n", hr);
unk_outer.AddRef_called = 0; ok(unk2 == unk, "Got unexpected IUnknown %p.\n", unk2);
unk_outer.Release_called = 0; IUnknown_Release(unk2);
hr = IUnknown_QueryInterface(pgraph, &IID_IFilterMapper2, (void **)&punk); hr = IUnknown_QueryInterface(unk, &IID_IFilterGraph2, (void **)&graph);
ok(hr == S_OK, "CoCreateInstance returned %x\n", hr); ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(punk != &unk_outer.IUnknown_iface, "punk = %p, expected not %p\n", punk, &unk_outer.IUnknown_iface);
IUnknown_Release(punk);
ok(unk_outer.AddRef_called == 1, "IUnknownImpl_AddRef called %d times\n", unk_outer.AddRef_called); hr = IFilterGraph2_QueryInterface(graph, &IID_IUnknown, (void **)&unk2);
ok(unk_outer.Release_called == 1, "IUnknownImpl_Release called %d times\n", unk_outer.Release_called); ok(hr == S_OK, "Got hr %#x.\n", hr);
unk_outer.AddRef_called = 0; ok(unk2 == (IUnknown *)0xdeadbeef, "Got unexpected IUnknown %p.\n", unk2);
unk_outer.Release_called = 0;
hr = IUnknown_QueryInterface(pgraph, &IID_IFilterMapper3, (void **)&punk); hr = IFilterGraph2_QueryInterface(graph, &IID_IFilterGraph2, (void **)&graph2);
ok(hr == S_OK, "CoCreateInstance returned %x\n", hr); ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(punk != &unk_outer.IUnknown_iface, "punk = %p, expected not %p\n", punk, &unk_outer.IUnknown_iface); ok(graph2 == (IFilterGraph2 *)0xdeadbeef, "Got unexpected IFilterGraph2 %p.\n", graph2);
IUnknown_Release(punk);
ok(unk_outer.AddRef_called == 1, "IUnknownImpl_AddRef called %d times\n", unk_outer.AddRef_called); hr = IUnknown_QueryInterface(unk, &test_iid, (void **)&unk2);
ok(unk_outer.Release_called == 1, "IUnknownImpl_Release called %d times\n", unk_outer.Release_called); ok(hr == E_NOINTERFACE, "Got hr %#x.\n", hr);
ok(!unk2, "Got unexpected IUnknown %p.\n", unk2);
IUnknown_Release(pgraph); hr = IFilterGraph2_QueryInterface(graph, &test_iid, (void **)&unk2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(unk2 == (IUnknown *)0xdeadbeef, "Got unexpected IUnknown %p.\n", unk2);
IFilterGraph2_Release(graph);
ref = IUnknown_Release(unk);
ok(!ref, "Got unexpected refcount %d.\n", ref);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
} }
/* Test how methods from "control" interfaces (IBasicAudio, IBasicVideo, /* Test how methods from "control" interfaces (IBasicAudio, IBasicVideo,
...@@ -3220,7 +3229,7 @@ START_TEST(filtergraph) ...@@ -3220,7 +3229,7 @@ START_TEST(filtergraph)
test_enum_filters(); test_enum_filters();
test_graph_builder_render(); test_graph_builder_render();
test_graph_builder_connect(); test_graph_builder_connect();
test_aggregate_filter_graph(); test_aggregation();
test_control_delegation(); test_control_delegation();
test_add_remove_filter(); test_add_remove_filter();
test_connect_direct(); test_connect_direct();
......
...@@ -27,6 +27,13 @@ ...@@ -27,6 +27,13 @@
#include "initguid.h" #include "initguid.h"
#include "wine/fil_data.h" #include "wine/fil_data.h"
static ULONG get_refcount(void *iface)
{
IUnknown *unknown = iface;
IUnknown_AddRef(unknown);
return IUnknown_Release(unknown);
}
/* Helper function, checks if filter with given name was enumerated. */ /* Helper function, checks if filter with given name was enumerated. */
static BOOL enum_find_filter(const WCHAR *wszFilterName, IEnumMoniker *pEnum) static BOOL enum_find_filter(const WCHAR *wszFilterName, IEnumMoniker *pEnum)
{ {
...@@ -527,96 +534,98 @@ out: ...@@ -527,96 +534,98 @@ out:
IFilterMapper2_Release(pMapper); IFilterMapper2_Release(pMapper);
} }
typedef struct IUnknownImpl static const GUID test_iid = {0x33333333};
{ static LONG outer_ref = 1;
IUnknown IUnknown_iface;
int AddRef_called;
int Release_called;
} IUnknownImpl;
static IUnknownImpl *IUnknownImpl_from_iface(IUnknown * iface)
{
return CONTAINING_RECORD(iface, IUnknownImpl, IUnknown_iface);
}
static HRESULT WINAPI IUnknownImpl_QueryInterface(IUnknown * iface, REFIID riid, LPVOID * ppv) static HRESULT WINAPI outer_QueryInterface(IUnknown *iface, REFIID iid, void **out)
{ {
ok(0, "QueryInterface should not be called for %s\n", wine_dbgstr_guid(riid)); if (IsEqualGUID(iid, &IID_IUnknown)
|| IsEqualGUID(iid, &IID_IFilterMapper3)
|| IsEqualGUID(iid, &test_iid))
{
*out = (IUnknown *)0xdeadbeef;
return S_OK;
}
ok(0, "unexpected call %s\n", wine_dbgstr_guid(iid));
return E_NOINTERFACE; return E_NOINTERFACE;
} }
static ULONG WINAPI IUnknownImpl_AddRef(IUnknown * iface) static ULONG WINAPI outer_AddRef(IUnknown *iface)
{ {
IUnknownImpl *This = IUnknownImpl_from_iface(iface); return InterlockedIncrement(&outer_ref);
This->AddRef_called++;
return 2;
} }
static ULONG WINAPI IUnknownImpl_Release(IUnknown * iface) static ULONG WINAPI outer_Release(IUnknown *iface)
{ {
IUnknownImpl *This = IUnknownImpl_from_iface(iface); return InterlockedDecrement(&outer_ref);
This->Release_called++;
return 1;
} }
static CONST_VTBL IUnknownVtbl IUnknownImpl_Vtbl = static const IUnknownVtbl outer_vtbl =
{ {
IUnknownImpl_QueryInterface, outer_QueryInterface,
IUnknownImpl_AddRef, outer_AddRef,
IUnknownImpl_Release outer_Release,
}; };
static void test_aggregate_filter_mapper(void) static IUnknown test_outer = {&outer_vtbl};
static void test_aggregation(void)
{ {
IFilterMapper3 *mapper, *mapper2;
IUnknown *unk, *unk2;
HRESULT hr; HRESULT hr;
IUnknown *pmapper; ULONG ref;
IUnknown *punk;
IUnknownImpl unk_outer = { { &IUnknownImpl_Vtbl }, 0, 0 }; mapper = (IFilterMapper3 *)0xdeadbeef;
hr = CoCreateInstance(&CLSID_FilterMapper2, &test_outer, CLSCTX_INPROC_SERVER,
hr = CoCreateInstance(&CLSID_FilterMapper2, &unk_outer.IUnknown_iface, CLSCTX_INPROC_SERVER, &IID_IFilterMapper3, (void **)&mapper);
&IID_IUnknown, (void **)&pmapper); ok(hr == E_NOINTERFACE, "Got hr %#x.\n", hr);
ok(hr == S_OK, "CoCreateInstance returned %x\n", hr); ok(!mapper, "Got interface %p.\n", mapper);
ok(pmapper != &unk_outer.IUnknown_iface, "pmapper = %p, expected not %p\n", pmapper, &unk_outer.IUnknown_iface);
hr = CoCreateInstance(&CLSID_FilterMapper2, &test_outer, CLSCTX_INPROC_SERVER,
hr = IUnknown_QueryInterface(pmapper, &IID_IUnknown, (void **)&punk); &IID_IUnknown, (void **)&unk);
ok(hr == S_OK, "IUnknown_QueryInterface returned %x\n", hr); ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(punk != &unk_outer.IUnknown_iface, "punk = %p, expected not %p\n", punk, &unk_outer.IUnknown_iface); ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
IUnknown_Release(punk); ok(unk != &test_outer, "Returned IUnknown should not be outer IUnknown.\n");
ref = get_refcount(unk);
ok(unk_outer.AddRef_called == 0, "IUnknownImpl_AddRef called %d times\n", unk_outer.AddRef_called); ok(ref == 1, "Got unexpected refcount %d.\n", ref);
ok(unk_outer.Release_called == 0, "IUnknownImpl_Release called %d times\n", unk_outer.Release_called);
unk_outer.AddRef_called = 0; ref = IUnknown_AddRef(unk);
unk_outer.Release_called = 0; ok(ref == 2, "Got unexpected refcount %d.\n", ref);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
hr = IUnknown_QueryInterface(pmapper, &IID_IFilterMapper, (void **)&punk);
ok(hr == S_OK, "IUnknown_QueryInterface returned %x\n", hr); ref = IUnknown_Release(unk);
ok(punk != &unk_outer.IUnknown_iface, "punk = %p, expected not %p\n", punk, &unk_outer.IUnknown_iface); ok(ref == 1, "Got unexpected refcount %d.\n", ref);
IUnknown_Release(punk); ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
ok(unk_outer.AddRef_called == 1, "IUnknownImpl_AddRef called %d times\n", unk_outer.AddRef_called); hr = IUnknown_QueryInterface(unk, &IID_IUnknown, (void **)&unk2);
ok(unk_outer.Release_called == 1, "IUnknownImpl_Release called %d times\n", unk_outer.Release_called); ok(hr == S_OK, "Got hr %#x.\n", hr);
unk_outer.AddRef_called = 0; ok(unk2 == unk, "Got unexpected IUnknown %p.\n", unk2);
unk_outer.Release_called = 0; IUnknown_Release(unk2);
hr = IUnknown_QueryInterface(pmapper, &IID_IFilterMapper2, (void **)&punk); hr = IUnknown_QueryInterface(unk, &IID_IFilterMapper3, (void **)&mapper);
ok(hr == S_OK, "IUnknown_QueryInterface returned %x\n", hr); ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(punk != &unk_outer.IUnknown_iface, "punk = %p, expected not %p\n", punk, &unk_outer.IUnknown_iface);
IUnknown_Release(punk); hr = IFilterMapper3_QueryInterface(mapper, &IID_IUnknown, (void **)&unk2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(unk_outer.AddRef_called == 1, "IUnknownImpl_AddRef called %d times\n", unk_outer.AddRef_called); ok(unk2 == (IUnknown *)0xdeadbeef, "Got unexpected IUnknown %p.\n", unk2);
ok(unk_outer.Release_called == 1, "IUnknownImpl_Release called %d times\n", unk_outer.Release_called);
unk_outer.AddRef_called = 0; hr = IFilterMapper3_QueryInterface(mapper, &IID_IFilterMapper3, (void **)&mapper2);
unk_outer.Release_called = 0; ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(mapper2 == (IFilterMapper3 *)0xdeadbeef, "Got unexpected IFilterMapper3 %p.\n", mapper2);
hr = IUnknown_QueryInterface(pmapper, &IID_IFilterMapper3, (void **)&punk);
ok(hr == S_OK, "IUnknown_QueryInterface returned %x\n", hr); hr = IUnknown_QueryInterface(unk, &test_iid, (void **)&unk2);
ok(punk != &unk_outer.IUnknown_iface, "punk = %p, expected not %p\n", punk, &unk_outer.IUnknown_iface); ok(hr == E_NOINTERFACE, "Got hr %#x.\n", hr);
IUnknown_Release(punk); ok(!unk2, "Got unexpected IUnknown %p.\n", unk2);
ok(unk_outer.AddRef_called == 1, "IUnknownImpl_AddRef called %d times\n", unk_outer.AddRef_called); hr = IFilterMapper3_QueryInterface(mapper, &test_iid, (void **)&unk2);
ok(unk_outer.Release_called == 1, "IUnknownImpl_Release called %d times\n", unk_outer.Release_called); ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(unk2 == (IUnknown *)0xdeadbeef, "Got unexpected IUnknown %p.\n", unk2);
IUnknown_Release(pmapper);
IFilterMapper3_Release(mapper);
ref = IUnknown_Release(unk);
ok(!ref, "Got unexpected refcount %d.\n", ref);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
} }
START_TEST(filtermapper) START_TEST(filtermapper)
...@@ -628,7 +637,7 @@ START_TEST(filtermapper) ...@@ -628,7 +637,7 @@ START_TEST(filtermapper)
test_ifiltermapper_from_filtergraph(); test_ifiltermapper_from_filtergraph();
test_register_filter_with_null_clsMinorType(); test_register_filter_with_null_clsMinorType();
test_parse_filter_data(); test_parse_filter_data();
test_aggregate_filter_mapper(); test_aggregation();
CoUninitialize(); CoUninitialize();
} }
/*
* Misc unit tests for Quartz
*
* Copyright (C) 2007 Google (Lei Zhang)
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
*/
#define COBJMACROS
#include "wine/test.h"
#include "dshow.h"
#define QI_SUCCEED(iface, riid, ppv) hr = IUnknown_QueryInterface(iface, &riid, (LPVOID*)&ppv); \
ok(hr == S_OK, "IUnknown_QueryInterface returned %x\n", hr); \
ok(ppv != NULL, "Pointer is NULL\n");
#define QI_FAIL(iface, riid, ppv) hr = IUnknown_QueryInterface(iface, &riid, (LPVOID*)&ppv); \
ok(hr == E_NOINTERFACE, "IUnknown_QueryInterface returned %x\n", hr); \
ok(ppv == NULL, "Pointer is %p\n", ppv);
#define ADDREF_EXPECT(iface, num) if (iface) { \
refCount = IUnknown_AddRef(iface); \
ok(refCount == num, "IUnknown_AddRef should return %d, got %d\n", num, refCount); \
}
#define RELEASE_EXPECT(iface, num) if (iface) { \
refCount = IUnknown_Release(iface); \
ok(refCount == num, "IUnknown_Release should return %d, got %d\n", num, refCount); \
}
static void test_aggregation(const CLSID clsidOuter, const CLSID clsidInner,
const IID iidOuter, const IID iidInner)
{
HRESULT hr;
ULONG refCount;
IUnknown *pUnkOuter = NULL;
IUnknown *pUnkInner = NULL;
IUnknown *pUnkInnerFail = NULL;
IUnknown *pUnkOuterTest = NULL;
IUnknown *pUnkInnerTest = NULL;
IUnknown *pUnkAggregatee = NULL;
IUnknown *pUnkAggregator = NULL;
IUnknown *pUnkTest = NULL;
hr = CoCreateInstance(&clsidOuter, NULL, CLSCTX_INPROC_SERVER,
&IID_IUnknown, (LPVOID*)&pUnkOuter);
ok(hr == S_OK, "CoCreateInstance failed with %x\n", hr);
ok(pUnkOuter != NULL, "pUnkOuter is NULL\n");
if (!pUnkOuter)
{
skip("pUnkOuter is NULL\n");
return;
}
/* for aggregation, we should only be able to request IUnknown */
hr = CoCreateInstance(&clsidInner, pUnkOuter, CLSCTX_INPROC_SERVER,
&iidInner, (LPVOID*)&pUnkInnerFail);
if (hr == REGDB_E_CLASSNOTREG)
{
skip("Class not registered\n");
return;
}
ok(hr == E_NOINTERFACE, "CoCreateInstance returned %x\n", hr);
ok(pUnkInnerFail == NULL, "pUnkInnerFail is not NULL\n");
/* aggregation, request IUnknown */
hr = CoCreateInstance(&clsidInner, pUnkOuter, CLSCTX_INPROC_SERVER,
&IID_IUnknown, (LPVOID*)&pUnkInner);
ok(hr == S_OK, "CoCreateInstance returned %x\n", hr);
ok(pUnkInner != NULL, "pUnkInner is NULL\n");
if (!pUnkInner)
{
skip("pUnkInner is NULL\n");
return;
}
ADDREF_EXPECT(pUnkOuter, 2);
ADDREF_EXPECT(pUnkInner, 2);
RELEASE_EXPECT(pUnkOuter, 1);
RELEASE_EXPECT(pUnkInner, 1);
QI_FAIL(pUnkOuter, iidInner, pUnkAggregatee);
QI_FAIL(pUnkInner, iidOuter, pUnkAggregator);
/* these QueryInterface calls should work */
QI_SUCCEED(pUnkOuter, iidOuter, pUnkAggregator);
QI_SUCCEED(pUnkOuter, IID_IUnknown, pUnkOuterTest);
/* IGraphConfig interface comes with DirectShow 9 */
if(IsEqualGUID(&IID_IGraphConfig, &iidInner))
{
hr = IUnknown_QueryInterface(pUnkInner, &iidInner, (LPVOID*)&pUnkAggregatee);
ok(hr == S_OK || broken(hr == E_NOINTERFACE), "IUnknown_QueryInterface returned %x\n", hr);
ok(pUnkAggregatee != NULL || broken(!pUnkAggregatee), "Pointer is NULL\n");
}
else
{
QI_SUCCEED(pUnkInner, iidInner, pUnkAggregatee);
}
QI_SUCCEED(pUnkInner, IID_IUnknown, pUnkInnerTest);
if (!pUnkAggregator || !pUnkOuterTest || !pUnkAggregatee
|| !pUnkInnerTest)
{
skip("One of the required interfaces is NULL\n");
return;
}
ADDREF_EXPECT(pUnkAggregator, 5);
ADDREF_EXPECT(pUnkOuterTest, 6);
ADDREF_EXPECT(pUnkAggregatee, 7);
ADDREF_EXPECT(pUnkInnerTest, 3);
RELEASE_EXPECT(pUnkAggregator, 6);
RELEASE_EXPECT(pUnkOuterTest, 5);
RELEASE_EXPECT(pUnkAggregatee, 4);
RELEASE_EXPECT(pUnkInnerTest, 2);
QI_SUCCEED(pUnkAggregator, IID_IUnknown, pUnkTest);
QI_SUCCEED(pUnkOuterTest, IID_IUnknown, pUnkTest);
QI_SUCCEED(pUnkAggregatee, IID_IUnknown, pUnkTest);
QI_SUCCEED(pUnkInnerTest, IID_IUnknown, pUnkTest);
QI_FAIL(pUnkAggregator, iidInner, pUnkTest);
QI_FAIL(pUnkOuterTest, iidInner, pUnkTest);
QI_FAIL(pUnkAggregatee, iidInner, pUnkTest);
QI_SUCCEED(pUnkInnerTest, iidInner, pUnkTest);
QI_SUCCEED(pUnkAggregator, iidOuter, pUnkTest);
QI_SUCCEED(pUnkOuterTest, iidOuter, pUnkTest);
QI_SUCCEED(pUnkAggregatee, iidOuter, pUnkTest);
QI_FAIL(pUnkInnerTest, iidOuter, pUnkTest);
RELEASE_EXPECT(pUnkAggregator, 10);
RELEASE_EXPECT(pUnkOuterTest, 9);
RELEASE_EXPECT(pUnkAggregatee, 8);
RELEASE_EXPECT(pUnkInnerTest, 2);
RELEASE_EXPECT(pUnkOuter, 7);
RELEASE_EXPECT(pUnkInner, 1);
do
{
refCount = IUnknown_Release(pUnkInner);
} while (refCount);
do
{
refCount = IUnknown_Release(pUnkOuter);
} while (refCount);
}
static void test_null_renderer_aggregations(void)
{
const IID * iids[] = {
&IID_IMediaFilter, &IID_IBaseFilter
};
int i;
for (i = 0; i < ARRAY_SIZE(iids); i++)
{
test_aggregation(CLSID_SystemClock, CLSID_NullRenderer, IID_IReferenceClock, *iids[i]);
}
}
static void test_video_renderer_aggregations(void)
{
const IID * iids[] = {
&IID_IMediaFilter, &IID_IBaseFilter, &IID_IBasicVideo, &IID_IVideoWindow
};
int i;
for (i = 0; i < ARRAY_SIZE(iids); i++)
{
test_aggregation(CLSID_SystemClock, CLSID_VideoRenderer,
IID_IReferenceClock, *iids[i]);
}
}
static void test_filter_graph_aggregations(void)
{
const IID * iids[] = {
&IID_IFilterGraph2, &IID_IMediaControl, &IID_IGraphBuilder,
&IID_IFilterGraph, &IID_IMediaSeeking, &IID_IBasicAudio, &IID_IBasicVideo,
&IID_IVideoWindow, &IID_IMediaEventEx, &IID_IMediaFilter,
&IID_IMediaEventSink, &IID_IGraphConfig, &IID_IMediaPosition
};
int i;
for (i = 0; i < ARRAY_SIZE(iids); i++)
{
test_aggregation(CLSID_SystemClock, CLSID_FilterGraph,
IID_IReferenceClock, *iids[i]);
}
}
static void test_filter_mapper_aggregations(void)
{
const IID * iids[] = {
&IID_IFilterMapper2, &IID_IFilterMapper
};
int i;
for (i = 0; i < ARRAY_SIZE(iids); i++)
{
test_aggregation(CLSID_SystemClock, CLSID_FilterMapper2,
IID_IReferenceClock, *iids[i]);
}
}
START_TEST(misc)
{
CoInitialize(NULL);
test_null_renderer_aggregations();
test_video_renderer_aggregations();
test_filter_graph_aggregations();
test_filter_mapper_aggregations();
CoUninitialize();
}
...@@ -99,6 +99,99 @@ static void test_interfaces(void) ...@@ -99,6 +99,99 @@ static void test_interfaces(void)
IBaseFilter_Release(filter); IBaseFilter_Release(filter);
} }
static const GUID test_iid = {0x33333333};
static LONG outer_ref = 1;
static HRESULT WINAPI outer_QueryInterface(IUnknown *iface, REFIID iid, void **out)
{
if (IsEqualGUID(iid, &IID_IUnknown)
|| IsEqualGUID(iid, &IID_IBaseFilter)
|| IsEqualGUID(iid, &test_iid))
{
*out = (IUnknown *)0xdeadbeef;
return S_OK;
}
ok(0, "unexpected call %s\n", wine_dbgstr_guid(iid));
return E_NOINTERFACE;
}
static ULONG WINAPI outer_AddRef(IUnknown *iface)
{
return InterlockedIncrement(&outer_ref);
}
static ULONG WINAPI outer_Release(IUnknown *iface)
{
return InterlockedDecrement(&outer_ref);
}
static const IUnknownVtbl outer_vtbl =
{
outer_QueryInterface,
outer_AddRef,
outer_Release,
};
static IUnknown test_outer = {&outer_vtbl};
static void test_aggregation(void)
{
IBaseFilter *filter, *filter2;
IUnknown *unk, *unk2;
HRESULT hr;
ULONG ref;
filter = (IBaseFilter *)0xdeadbeef;
hr = CoCreateInstance(&CLSID_VideoRenderer, &test_outer, CLSCTX_INPROC_SERVER,
&IID_IBaseFilter, (void **)&filter);
ok(hr == E_NOINTERFACE, "Got hr %#x.\n", hr);
ok(!filter, "Got interface %p.\n", filter);
hr = CoCreateInstance(&CLSID_VideoRenderer, &test_outer, CLSCTX_INPROC_SERVER,
&IID_IUnknown, (void **)&unk);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
ok(unk != &test_outer, "Returned IUnknown should not be outer IUnknown.\n");
ref = get_refcount(unk);
ok(ref == 1, "Got unexpected refcount %d.\n", ref);
ref = IUnknown_AddRef(unk);
ok(ref == 2, "Got unexpected refcount %d.\n", ref);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
ref = IUnknown_Release(unk);
ok(ref == 1, "Got unexpected refcount %d.\n", ref);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
hr = IUnknown_QueryInterface(unk, &IID_IUnknown, (void **)&unk2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(unk2 == unk, "Got unexpected IUnknown %p.\n", unk2);
IUnknown_Release(unk2);
hr = IUnknown_QueryInterface(unk, &IID_IBaseFilter, (void **)&filter);
ok(hr == S_OK, "Got hr %#x.\n", hr);
hr = IBaseFilter_QueryInterface(filter, &IID_IUnknown, (void **)&unk2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(unk2 == (IUnknown *)0xdeadbeef, "Got unexpected IUnknown %p.\n", unk2);
hr = IBaseFilter_QueryInterface(filter, &IID_IBaseFilter, (void **)&filter2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(filter2 == (IBaseFilter *)0xdeadbeef, "Got unexpected IBaseFilter %p.\n", filter2);
hr = IUnknown_QueryInterface(unk, &test_iid, (void **)&unk2);
ok(hr == E_NOINTERFACE, "Got hr %#x.\n", hr);
ok(!unk2, "Got unexpected IUnknown %p.\n", unk2);
hr = IBaseFilter_QueryInterface(filter, &test_iid, (void **)&unk2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(unk2 == (IUnknown *)0xdeadbeef, "Got unexpected IUnknown %p.\n", unk2);
IBaseFilter_Release(filter);
ref = IUnknown_Release(unk);
ok(!ref, "Got unexpected refcount %d.\n", ref);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
}
static void test_enum_pins(void) static void test_enum_pins(void)
{ {
...@@ -398,6 +491,7 @@ START_TEST(videorenderer) ...@@ -398,6 +491,7 @@ START_TEST(videorenderer)
CoInitialize(NULL); CoInitialize(NULL);
test_interfaces(); test_interfaces();
test_aggregation();
test_enum_pins(); test_enum_pins();
test_find_pin(); test_find_pin();
test_pin_info(); test_pin_info();
......
...@@ -306,6 +306,100 @@ static void test_interfaces(void) ...@@ -306,6 +306,100 @@ static void test_interfaces(void)
ok(!ref, "Got outstanding refcount %d.\n", ref); ok(!ref, "Got outstanding refcount %d.\n", ref);
} }
static const GUID test_iid = {0x33333333};
static LONG outer_ref = 1;
static HRESULT WINAPI outer_QueryInterface(IUnknown *iface, REFIID iid, void **out)
{
if (IsEqualGUID(iid, &IID_IUnknown)
|| IsEqualGUID(iid, &IID_IBaseFilter)
|| IsEqualGUID(iid, &test_iid))
{
*out = (IUnknown *)0xdeadbeef;
return S_OK;
}
ok(0, "unexpected call %s\n", wine_dbgstr_guid(iid));
return E_NOINTERFACE;
}
static ULONG WINAPI outer_AddRef(IUnknown *iface)
{
return InterlockedIncrement(&outer_ref);
}
static ULONG WINAPI outer_Release(IUnknown *iface)
{
return InterlockedDecrement(&outer_ref);
}
static const IUnknownVtbl outer_vtbl =
{
outer_QueryInterface,
outer_AddRef,
outer_Release,
};
static IUnknown test_outer = {&outer_vtbl};
static void test_aggregation(void)
{
IBaseFilter *filter, *filter2;
IUnknown *unk, *unk2;
HRESULT hr;
ULONG ref;
filter = (IBaseFilter *)0xdeadbeef;
hr = CoCreateInstance(&CLSID_VideoMixingRenderer, &test_outer, CLSCTX_INPROC_SERVER,
&IID_IBaseFilter, (void **)&filter);
ok(hr == E_NOINTERFACE, "Got hr %#x.\n", hr);
ok(!filter, "Got interface %p.\n", filter);
hr = CoCreateInstance(&CLSID_VideoMixingRenderer, &test_outer, CLSCTX_INPROC_SERVER,
&IID_IUnknown, (void **)&unk);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
ok(unk != &test_outer, "Returned IUnknown should not be outer IUnknown.\n");
ref = get_refcount(unk);
ok(ref == 1, "Got unexpected refcount %d.\n", ref);
ref = IUnknown_AddRef(unk);
ok(ref == 2, "Got unexpected refcount %d.\n", ref);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
ref = IUnknown_Release(unk);
ok(ref == 1, "Got unexpected refcount %d.\n", ref);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
hr = IUnknown_QueryInterface(unk, &IID_IUnknown, (void **)&unk2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(unk2 == unk, "Got unexpected IUnknown %p.\n", unk2);
IUnknown_Release(unk2);
hr = IUnknown_QueryInterface(unk, &IID_IBaseFilter, (void **)&filter);
ok(hr == S_OK, "Got hr %#x.\n", hr);
hr = IBaseFilter_QueryInterface(filter, &IID_IUnknown, (void **)&unk2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(unk2 == (IUnknown *)0xdeadbeef, "Got unexpected IUnknown %p.\n", unk2);
hr = IBaseFilter_QueryInterface(filter, &IID_IBaseFilter, (void **)&filter2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(filter2 == (IBaseFilter *)0xdeadbeef, "Got unexpected IBaseFilter %p.\n", filter2);
hr = IUnknown_QueryInterface(unk, &test_iid, (void **)&unk2);
ok(hr == E_NOINTERFACE, "Got hr %#x.\n", hr);
ok(!unk2, "Got unexpected IUnknown %p.\n", unk2);
hr = IBaseFilter_QueryInterface(filter, &test_iid, (void **)&unk2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(unk2 == (IUnknown *)0xdeadbeef, "Got unexpected IUnknown %p.\n", unk2);
IBaseFilter_Release(filter);
ref = IUnknown_Release(unk);
ok(!ref, "Got unexpected refcount %d.\n", ref);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
}
static void test_enum_pins(void) static void test_enum_pins(void)
{ {
IBaseFilter *filter = create_vmr7(0); IBaseFilter *filter = create_vmr7(0);
...@@ -573,6 +667,7 @@ START_TEST(vmr7) ...@@ -573,6 +667,7 @@ START_TEST(vmr7)
test_filter_config(); test_filter_config();
test_interfaces(); test_interfaces();
test_aggregation();
test_enum_pins(); test_enum_pins();
test_find_pin(); test_find_pin();
test_pin_info(); test_pin_info();
......
...@@ -299,6 +299,100 @@ static void test_interfaces(void) ...@@ -299,6 +299,100 @@ static void test_interfaces(void)
ok(!ref, "Got outstanding refcount %d.\n", ref); ok(!ref, "Got outstanding refcount %d.\n", ref);
} }
static const GUID test_iid = {0x33333333};
static LONG outer_ref = 1;
static HRESULT WINAPI outer_QueryInterface(IUnknown *iface, REFIID iid, void **out)
{
if (IsEqualGUID(iid, &IID_IUnknown)
|| IsEqualGUID(iid, &IID_IBaseFilter)
|| IsEqualGUID(iid, &test_iid))
{
*out = (IUnknown *)0xdeadbeef;
return S_OK;
}
ok(0, "unexpected call %s\n", wine_dbgstr_guid(iid));
return E_NOINTERFACE;
}
static ULONG WINAPI outer_AddRef(IUnknown *iface)
{
return InterlockedIncrement(&outer_ref);
}
static ULONG WINAPI outer_Release(IUnknown *iface)
{
return InterlockedDecrement(&outer_ref);
}
static const IUnknownVtbl outer_vtbl =
{
outer_QueryInterface,
outer_AddRef,
outer_Release,
};
static IUnknown test_outer = {&outer_vtbl};
static void test_aggregation(void)
{
IBaseFilter *filter, *filter2;
IUnknown *unk, *unk2;
HRESULT hr;
ULONG ref;
filter = (IBaseFilter *)0xdeadbeef;
hr = CoCreateInstance(&CLSID_VideoMixingRenderer, &test_outer, CLSCTX_INPROC_SERVER,
&IID_IBaseFilter, (void **)&filter);
ok(hr == E_NOINTERFACE, "Got hr %#x.\n", hr);
ok(!filter, "Got interface %p.\n", filter);
hr = CoCreateInstance(&CLSID_VideoMixingRenderer, &test_outer, CLSCTX_INPROC_SERVER,
&IID_IUnknown, (void **)&unk);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
ok(unk != &test_outer, "Returned IUnknown should not be outer IUnknown.\n");
ref = get_refcount(unk);
ok(ref == 1, "Got unexpected refcount %d.\n", ref);
ref = IUnknown_AddRef(unk);
ok(ref == 2, "Got unexpected refcount %d.\n", ref);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
ref = IUnknown_Release(unk);
ok(ref == 1, "Got unexpected refcount %d.\n", ref);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
hr = IUnknown_QueryInterface(unk, &IID_IUnknown, (void **)&unk2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(unk2 == unk, "Got unexpected IUnknown %p.\n", unk2);
IUnknown_Release(unk2);
hr = IUnknown_QueryInterface(unk, &IID_IBaseFilter, (void **)&filter);
ok(hr == S_OK, "Got hr %#x.\n", hr);
hr = IBaseFilter_QueryInterface(filter, &IID_IUnknown, (void **)&unk2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(unk2 == (IUnknown *)0xdeadbeef, "Got unexpected IUnknown %p.\n", unk2);
hr = IBaseFilter_QueryInterface(filter, &IID_IBaseFilter, (void **)&filter2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(filter2 == (IBaseFilter *)0xdeadbeef, "Got unexpected IBaseFilter %p.\n", filter2);
hr = IUnknown_QueryInterface(unk, &test_iid, (void **)&unk2);
ok(hr == E_NOINTERFACE, "Got hr %#x.\n", hr);
ok(!unk2, "Got unexpected IUnknown %p.\n", unk2);
hr = IBaseFilter_QueryInterface(filter, &test_iid, (void **)&unk2);
ok(hr == S_OK, "Got hr %#x.\n", hr);
ok(unk2 == (IUnknown *)0xdeadbeef, "Got unexpected IUnknown %p.\n", unk2);
IBaseFilter_Release(filter);
ref = IUnknown_Release(unk);
ok(!ref, "Got unexpected refcount %d.\n", ref);
ok(outer_ref == 1, "Got unexpected refcount %d.\n", outer_ref);
}
static HRESULT set_mixing_mode(IBaseFilter *filter) static HRESULT set_mixing_mode(IBaseFilter *filter)
{ {
IVMRFilterConfig9 *config; IVMRFilterConfig9 *config;
...@@ -586,6 +680,7 @@ START_TEST(vmr9) ...@@ -586,6 +680,7 @@ START_TEST(vmr9)
test_filter_config(); test_filter_config();
test_interfaces(); test_interfaces();
test_aggregation();
test_enum_pins(); test_enum_pins();
test_find_pin(); test_find_pin();
test_pin_info(); test_pin_info();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment