rpcrt4: Use an alertable wait in rpcrt4_protseq_np_wait_for_new_connection to…

rpcrt4: Use an alertable wait in rpcrt4_protseq_np_wait_for_new_connection to fix a small memory leak flagged by Valgrind. This is called only by the RPCRT4_server_thread so we don't have to worry about application user APCs being run at improper times.

rpcrt4: Use an alertable wait in rpcrt4_protseq_np_wait_for_new_connection to…
7092590c · Rob Shearman · Alexandre Julliard · 83a02c54 · 7092590c
Commit 7092590c authored Dec 06, 2007 by Rob Shearman Committed by Alexandre Julliard Dec 07, 2007
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 2 deletions

rpc_transport.c dlls/rpcrt4/rpc_transport.c +10 -2

No files found.
--- a/dlls/rpcrt4/rpc_transport.c
+++ b/dlls/rpcrt4/rpc_transport.c
@@ -604,8 +604,16 @@ static int rpcrt4_protseq_np_wait_for_new_connection(RpcServerProtseq *protseq, 
    
    if (!objs)
        return -1;
-    
-    res = WaitForMultipleObjects(count, objs, FALSE, INFINITE);
+
+    do
+    {
+        /* an alertable wait isn't strictly necessary, but due to our
+         * overlapped I/O implementation in Wine we need to free some memory
+         * by the file user APC being called, even if no completion routine was
+         * specified at the time of starting the async operation */
+        res = WaitForMultipleObjectsEx(count, objs, FALSE, INFINITE, TRUE);
+    } while (res == WAIT_IO_COMPLETION);
+
    if (res == WAIT_OBJECT_0)
        return 0;
    else if (res == WAIT_FAILED)