Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
73fd4b09
Commit
73fd4b09
authored
May 08, 2018
by
Jacek Caban
Committed by
Alexandre Julliard
May 08, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
urlmon: Don't store IWinInetHttpInfo reference in BindProtocol.
Signed-off-by:
Jacek Caban
<
jacek@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
357da1e8
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
24 additions
and
13 deletions
+24
-13
binding.c
dlls/urlmon/binding.c
+24
-7
bindprot.c
dlls/urlmon/bindprot.c
+0
-5
urlmon_main.h
dlls/urlmon/urlmon_main.h
+0
-1
No files found.
dlls/urlmon/binding.c
View file @
73fd4b09
...
@@ -800,12 +800,20 @@ static HRESULT WINAPI Binding_QueryInterface(IBinding *iface, REFIID riid, void
...
@@ -800,12 +800,20 @@ static HRESULT WINAPI Binding_QueryInterface(IBinding *iface, REFIID riid, void
*
ppv
=
&
This
->
IWinInetHttpInfo_iface
;
*
ppv
=
&
This
->
IWinInetHttpInfo_iface
;
}
else
if
(
IsEqualGUID
(
&
IID_IWinInetHttpInfo
,
riid
))
{
}
else
if
(
IsEqualGUID
(
&
IID_IWinInetHttpInfo
,
riid
))
{
TRACE
(
"(%p)->(IID_IWinInetHttpInfo %p)
\n
"
,
This
,
ppv
);
IWinInetHttpInfo
*
http_info
;
HRESULT
hres
;
if
(
!
This
->
protocol
->
wininet_http_info
)
TRACE
(
"(%p)->(IID_IWinInetHttpInfo %p)
\n
"
,
This
,
ppv
);
return
E_NOINTERFACE
;
*
ppv
=
&
This
->
IWinInetHttpInfo_iface
;
/* NOTE: This violidates COM rules, but tests prove that we should do it */
if
(
This
->
protocol
->
protocol_unk
)
{
hres
=
IUnknown_QueryInterface
(
This
->
protocol
->
protocol_unk
,
&
IID_IWinInetHttpInfo
,
(
void
**
)
&
http_info
);
if
(
SUCCEEDED
(
hres
))
{
IWinInetHttpInfo_Release
(
http_info
);
*
ppv
=
&
This
->
IWinInetHttpInfo_iface
;
}
}
}
}
if
(
*
ppv
)
{
if
(
*
ppv
)
{
...
@@ -1318,13 +1326,22 @@ static HRESULT WINAPI WinInetHttpInfo_QueryInfo(IWinInetHttpInfo *iface, DWORD d
...
@@ -1318,13 +1326,22 @@ static HRESULT WINAPI WinInetHttpInfo_QueryInfo(IWinInetHttpInfo *iface, DWORD d
void
*
pBuffer
,
DWORD
*
pcbBuffer
,
DWORD
*
pdwFlags
,
DWORD
*
pdwReserved
)
void
*
pBuffer
,
DWORD
*
pcbBuffer
,
DWORD
*
pdwFlags
,
DWORD
*
pdwReserved
)
{
{
Binding
*
This
=
impl_from_IWinInetHttpInfo
(
iface
);
Binding
*
This
=
impl_from_IWinInetHttpInfo
(
iface
);
IWinInetHttpInfo
*
http_info
;
HRESULT
hres
;
TRACE
(
"(%p)->(%x %p %p %p %p)
\n
"
,
This
,
dwOption
,
pBuffer
,
pcbBuffer
,
pdwFlags
,
pdwReserved
);
TRACE
(
"(%p)->(%x %p %p %p %p)
\n
"
,
This
,
dwOption
,
pBuffer
,
pcbBuffer
,
pdwFlags
,
pdwReserved
);
if
(
!
This
->
protocol
->
wininet_http_info
)
if
(
!
This
->
protocol
->
protocol_unk
)
return
E_FAIL
;
hres
=
IUnknown_QueryInterface
(
This
->
protocol
->
protocol_unk
,
&
IID_IWinInetHttpInfo
,
(
void
**
)
&
http_info
);
if
(
FAILED
(
hres
))
return
E_FAIL
;
return
E_FAIL
;
return
IWinInetHttpInfo_QueryInfo
(
This
->
protocol
->
wininet_http_info
,
hres
=
IWinInetHttpInfo_QueryInfo
(
http_info
,
dwOption
,
pBuffer
,
pcbBuffer
,
pdwFlags
,
pdwReserved
);
dwOption
,
pBuffer
,
pcbBuffer
,
pdwFlags
,
pdwReserved
);
IWinInetHttpInfo_Release
(
http_info
);
return
hres
;
}
}
static
const
IWinInetHttpInfoVtbl
WinInetHttpInfoVtbl
=
{
static
const
IWinInetHttpInfoVtbl
WinInetHttpInfoVtbl
=
{
...
...
dlls/urlmon/bindprot.c
View file @
73fd4b09
...
@@ -334,10 +334,6 @@ static void release_protocol_handler(BindProtocol *This)
...
@@ -334,10 +334,6 @@ static void release_protocol_handler(BindProtocol *This)
IWinInetInfo_Release
(
This
->
wininet_info
);
IWinInetInfo_Release
(
This
->
wininet_info
);
This
->
wininet_info
=
NULL
;
This
->
wininet_info
=
NULL
;
}
}
if
(
This
->
wininet_http_info
)
{
IWinInetHttpInfo_Release
(
This
->
wininet_http_info
);
This
->
wininet_http_info
=
NULL
;
}
if
(
This
->
protocol_unk
)
{
if
(
This
->
protocol_unk
)
{
IUnknown_Release
(
This
->
protocol_unk
);
IUnknown_Release
(
This
->
protocol_unk
);
This
->
protocol_unk
=
NULL
;
This
->
protocol_unk
=
NULL
;
...
@@ -568,7 +564,6 @@ static HRESULT WINAPI BindProtocol_StartEx(IInternetProtocolEx *iface, IUri *pUr
...
@@ -568,7 +564,6 @@ static HRESULT WINAPI BindProtocol_StartEx(IInternetProtocolEx *iface, IUri *pUr
if
(
urlmon_protocol
)
{
if
(
urlmon_protocol
)
{
IInternetProtocol_QueryInterface
(
protocol
,
&
IID_IWinInetInfo
,
(
void
**
)
&
This
->
wininet_info
);
IInternetProtocol_QueryInterface
(
protocol
,
&
IID_IWinInetInfo
,
(
void
**
)
&
This
->
wininet_info
);
IInternetProtocol_QueryInterface
(
protocol
,
&
IID_IWinInetHttpInfo
,
(
void
**
)
&
This
->
wininet_http_info
);
}
}
set_binding_sink
(
This
,
pOIProtSink
,
pOIBindInfo
);
set_binding_sink
(
This
,
pOIProtSink
,
pOIBindInfo
);
...
...
dlls/urlmon/urlmon_main.h
View file @
73fd4b09
...
@@ -179,7 +179,6 @@ typedef struct {
...
@@ -179,7 +179,6 @@ typedef struct {
IUnknown
*
protocol_unk
;
IUnknown
*
protocol_unk
;
IInternetProtocol
*
protocol
;
IInternetProtocol
*
protocol
;
IWinInetInfo
*
wininet_info
;
IWinInetInfo
*
wininet_info
;
IWinInetHttpInfo
*
wininet_http_info
;
IInternetBindInfo
*
bind_info
;
IInternetBindInfo
*
bind_info
;
IInternetProtocolSink
*
protocol_sink
;
IInternetProtocolSink
*
protocol_sink
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment