server: Free ptr in console_input_append_hist.

Free ptr in console_input_append_hist before returning, otherwise it will be leaked (found by Coverity). Remove the setting of last error on mem_alloc failure, as it is already done in mem_alloc.

server: Free ptr in console_input_append_hist.
7a3df4d0 · Robert Shearman · Alexandre Julliard · 0bf1c22c · 7a3df4d0
Commit 7a3df4d0 authored Apr 07, 2006 by Robert Shearman Committed by Alexandre Julliard Apr 07, 2006
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 4 deletions

console.c server/console.c +3 -4

No files found.
--- a/server/console.c
+++ b/server/console.c
@@ -897,13 +897,12 @@ static void console_input_append_hist( struct console_input* console, const WCHA
    WCHAR*	ptr = mem_alloc( (len + 1) * sizeof(WCHAR) );

    if (!ptr)
-    {
-	set_error( STATUS_NO_MEMORY );
-	return;
-    }
+        return;
+
    if (!console || !console->history_size)
    {
 	set_error( STATUS_INVALID_PARAMETER ); /* FIXME */
+	free( ptr );
 	return;
    }