wined3d: Don't touch "ppSurface" on failure in IWineD3DDeviceImpl_CreateSurface().

I originally kept these when adding surface_init() in 5f581975 because the original code had them on most error paths. However, this actually broke ddraw because it assumed we don't touch "ppSurface" on errors. Just remove these since they're useless anyway.

wined3d: Don't touch "ppSurface" on failure in IWineD3DDeviceImpl_CreateSurface().
7fe3ab5a · Henri Verbeet · Alexandre Julliard · aa305c4a · 7fe3ab5a
Commit 7fe3ab5a authored Dec 17, 2009 by Henri Verbeet Committed by Alexandre Julliard Dec 18, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 2 deletions

device.c dlls/wined3d/device.c +0 -2

No files found.
--- a/dlls/wined3d/device.c
+++ b/dlls/wined3d/device.c
@@ -640,7 +640,6 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateSurface(IWineD3DDevice *iface, UI
    if (!object)
    {
        ERR("Failed to allocate surface memory.\n");
-        *ppSurface = NULL;
        return WINED3DERR_OUTOFVIDEOMEMORY;
    }

@@ -650,7 +649,6 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateSurface(IWineD3DDevice *iface, UI
    {
        WARN("Failed to initialize surface, returning %#x.\n", hr);
        HeapFree(GetProcessHeap(), 0, object);
-        *ppSurface = NULL;
        return hr;
    }