msvcrt: Make _beginthread() error out as documented.

msvcrt_set_errno() seems to be doing the right thing in case of too many threads, invalid parameters, etc. Signed-off-by: Arkadiusz Hiler <ahiler@codeweavers.com> Signed-off-by: Piotr Caban <piotr@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msvcrt: Make _beginthread() error out as documented.
80678c43 · Arkadiusz Hiler · Alexandre Julliard · af2b2d04 · 80678c43
Commit 80678c43 authored May 05, 2021 by Arkadiusz Hiler Committed by Alexandre Julliard May 05, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

thread.c dlls/msvcrt/thread.c +3 -1

No files found.
--- a/dlls/msvcrt/thread.c
+++ b/dlls/msvcrt/thread.c
@@ -118,6 +118,8 @@ uintptr_t CDECL _beginthread(

  TRACE("(%p, %d, %p)\n", start_address, stack_size, arglist);

+  if (!MSVCRT_CHECK_PMT(start_address)) return -1;
+
  trampoline = malloc(sizeof(*trampoline));
  if(!trampoline) {
      *_errno() = EAGAIN;
@@ -128,7 +130,7 @@ uintptr_t CDECL _beginthread(
          trampoline, CREATE_SUSPENDED, NULL);
  if(!thread) {
      free(trampoline);
-      *_errno() = EAGAIN;
+      msvcrt_set_errno(GetLastError());
      return -1;
  }