wininet: Always set last error in InternetReadFile.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47352Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wininet: Always set last error in InternetReadFile.
8f5b9f4d · Alistair Leslie-Hughes · Alexandre Julliard · 3522b127 · 8f5b9f4d · 8f5b9f4d
Commit 8f5b9f4d authored Jun 24, 2019 by Alistair Leslie-Hughes Committed by Alexandre Julliard Jun 24, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 2 deletions

internet.c dlls/wininet/internet.c +1 -2

http.c dlls/wininet/tests/http.c +6 -0

No files found.
--- a/dlls/wininet/internet.c
+++ b/dlls/wininet/internet.c
@@ -2193,8 +2193,7 @@ BOOL WINAPI InternetReadFile(HINTERNET hFile, LPVOID lpBuffer,
    TRACE("-- %s (%u) (bytes read: %d)\n", res == ERROR_SUCCESS ? "TRUE": "FALSE", res,
          pdwNumOfBytesRead ? *pdwNumOfBytesRead : -1);

-    if(res != ERROR_SUCCESS)
-        SetLastError(res);
+    SetLastError(res);
    return res == ERROR_SUCCESS;
 }


--- a/dlls/wininet/tests/http.c
+++ b/dlls/wininet/tests/http.c
@@ -987,7 +987,10 @@ static void InternetReadFile_chunked_test(void)
        {
            char *buffer = HeapAlloc(GetProcessHeap(),0,length+1);

+            SetLastError(0xdeadbeef);
            res = InternetReadFile(hor,buffer,length,&got);
+            ok(GetLastError() == 0 ||
+                broken(GetLastError() == 0xdeadbeef /* XP/W2K3 */), "Last Error not reset %u\n", GetLastError());

            buffer[got]=0;
            trace("ReadFile -> %i %i\n",res,got);
@@ -1000,8 +1003,11 @@ static void InternetReadFile_chunked_test(void)
        if (length == 0)
        {
            got = 0xdeadbeef;
+            SetLastError(0xdeadbeef);
            res = InternetReadFile( hor, buffer, 1, &got );
            ok( res, "InternetReadFile failed: %u\n", GetLastError() );
+            ok(GetLastError() == 0 ||
+                broken(GetLastError() == 0xdeadbeef /* XP/W2K3 */), "Last Error not reset %u\n", GetLastError());
            ok( !got, "got %u\n", got );
            break;
        }