widl: Only duplicate a type if absolutely necessary.

Document how much of hack duplicating a type in order to change its pointer type is.

widl: Only duplicate a type if absolutely necessary.
8f87eddd · Rob Shearman · Alexandre Julliard · e054c52c · 8f87eddd
Commit 8f87eddd authored Feb 14, 2009 by Rob Shearman Committed by Alexandre Julliard Feb 16, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 13 additions and 3 deletions

parser.y tools/widl/parser.y +13 -3

No files found.
--- a/tools/widl/parser.y
+++ b/tools/widl/parser.y
@@ -1446,9 +1446,19 @@ static void set_type(var_t *v, decl_spec_t *decl_spec, const declarator_t *decl,
    }
    if (ptr && is_ptr(ptr) && (ptr_attr || top))
    {
-      /* duplicate type to avoid changing original type */
+      if (!ptr_attr)
-      *pt = duptype(*pt, 1);
+        ptr_attr = RPC_FC_RP;
-      (*pt)->type = ptr_attr ? ptr_attr : RPC_FC_RP;
+      if (ptr_attr != (*pt)->type)
+      {
+        /* create new type to avoid changing original type */
+        /* FIXME: this is a horrible hack - we might be changing the pointer
+         * type of an alias here, so we also need corresponding hacks in
+         * get_pointer_fc to handle this. The type of pointer that the type
+         * ends up having is context sensitive and so we shouldn't be
+         * setting it here, but rather determining it when it is used. */
+        *pt = duptype(*pt, 1);
+        (*pt)->type = ptr_attr;
+      }
    }
    else if (ptr_attr)
       error_loc("%s: pointer attribute applied to non-pointer type\n", v->name);