Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
912f1a43
Commit
912f1a43
authored
Sep 18, 2023
by
Gabriel Ivăncescu
Committed by
Alexandre Julliard
Sep 18, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
mshtml: Get rid of useless element destructors.
Just use the HTMLElement_destructor directly. Signed-off-by:
Gabriel Ivăncescu
<
gabrielopcode@gmail.com
>
parent
13842950
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
8 additions
and
64 deletions
+8
-64
htmlcomment.c
dlls/mshtml/htmlcomment.c
+1
-8
htmlgeneric.c
dlls/mshtml/htmlgeneric.c
+1
-8
htmlhead.c
dlls/mshtml/htmlhead.c
+4
-32
htmlobject.c
dlls/mshtml/htmlobject.c
+1
-8
htmltable.c
dlls/mshtml/htmltable.c
+1
-8
No files found.
dlls/mshtml/htmlcomment.c
View file @
912f1a43
...
...
@@ -146,13 +146,6 @@ static inline HTMLCommentElement *impl_from_HTMLDOMNode(HTMLDOMNode *iface)
return
CONTAINING_RECORD
(
iface
,
HTMLCommentElement
,
element
.
node
);
}
static
void
HTMLCommentElement_destructor
(
HTMLDOMNode
*
iface
)
{
HTMLCommentElement
*
This
=
impl_from_HTMLDOMNode
(
iface
);
HTMLElement_destructor
(
&
This
->
element
.
node
);
}
static
HRESULT
HTMLCommentElement_clone
(
HTMLDOMNode
*
iface
,
nsIDOMNode
*
nsnode
,
HTMLDOMNode
**
ret
)
{
HTMLCommentElement
*
This
=
impl_from_HTMLDOMNode
(
iface
);
...
...
@@ -180,7 +173,7 @@ static void *HTMLCommentElement_QI(HTMLDOMNode *iface, REFIID riid)
static
const
NodeImplVtbl
HTMLCommentElementImplVtbl
=
{
.
clsid
=
&
CLSID_HTMLCommentElement
,
.
qi
=
HTMLCommentElement_QI
,
.
destructor
=
HTML
Comment
Element_destructor
,
.
destructor
=
HTMLElement_destructor
,
.
cpc_entries
=
HTMLElement_cpc
,
.
clone
=
HTMLCommentElement_clone
,
.
handle_event
=
HTMLElement_handle_event
,
...
...
dlls/mshtml/htmlgeneric.c
View file @
912f1a43
...
...
@@ -138,17 +138,10 @@ static void *HTMLGenericElement_QI(HTMLDOMNode *iface, REFIID riid)
return
HTMLElement_QI
(
&
This
->
element
.
node
,
riid
);
}
static
void
HTMLGenericElement_destructor
(
HTMLDOMNode
*
iface
)
{
HTMLGenericElement
*
This
=
impl_from_HTMLDOMNode
(
iface
);
HTMLElement_destructor
(
&
This
->
element
.
node
);
}
static
const
NodeImplVtbl
HTMLGenericElementImplVtbl
=
{
.
clsid
=
&
CLSID_HTMLGenericElement
,
.
qi
=
HTMLGenericElement_QI
,
.
destructor
=
HTML
Generic
Element_destructor
,
.
destructor
=
HTMLElement_destructor
,
.
cpc_entries
=
HTMLElement_cpc
,
.
clone
=
HTMLElement_clone
,
.
handle_event
=
HTMLElement_handle_event
,
...
...
dlls/mshtml/htmlhead.c
View file @
912f1a43
...
...
@@ -156,17 +156,10 @@ static void *HTMLTitleElement_QI(HTMLDOMNode *iface, REFIID riid)
return
HTMLElement_QI
(
&
This
->
element
.
node
,
riid
);
}
static
void
HTMLTitleElement_destructor
(
HTMLDOMNode
*
iface
)
{
HTMLTitleElement
*
This
=
HTMLTitleElement_from_HTMLDOMNode
(
iface
);
HTMLElement_destructor
(
&
This
->
element
.
node
);
}
static
const
NodeImplVtbl
HTMLTitleElementImplVtbl
=
{
.
clsid
=
&
CLSID_HTMLTitleElement
,
.
qi
=
HTMLTitleElement_QI
,
.
destructor
=
HTML
Title
Element_destructor
,
.
destructor
=
HTMLElement_destructor
,
.
cpc_entries
=
HTMLElement_cpc
,
.
clone
=
HTMLElement_clone
,
.
handle_event
=
HTMLElement_handle_event
,
...
...
@@ -303,13 +296,6 @@ static inline HTMLHtmlElement *HTMLHtmlElement_from_HTMLDOMNode(HTMLDOMNode *ifa
return
CONTAINING_RECORD
(
iface
,
HTMLHtmlElement
,
element
.
node
);
}
static
void
HTMLHtmlElement_destructor
(
HTMLDOMNode
*
iface
)
{
HTMLHtmlElement
*
This
=
HTMLHtmlElement_from_HTMLDOMNode
(
iface
);
HTMLElement_destructor
(
&
This
->
element
.
node
);
}
static
BOOL
HTMLHtmlElement_is_settable
(
HTMLDOMNode
*
iface
,
DISPID
dispid
)
{
switch
(
dispid
)
{
...
...
@@ -333,7 +319,7 @@ static void *HTMLHtmlElement_QI(HTMLDOMNode *iface, REFIID riid)
static
const
NodeImplVtbl
HTMLHtmlElementImplVtbl
=
{
.
clsid
=
&
CLSID_HTMLHtmlElement
,
.
qi
=
HTMLHtmlElement_QI
,
.
destructor
=
HTML
Html
Element_destructor
,
.
destructor
=
HTMLElement_destructor
,
.
cpc_entries
=
HTMLElement_cpc
,
.
clone
=
HTMLElement_clone
,
.
handle_event
=
HTMLElement_handle_event
,
...
...
@@ -553,17 +539,10 @@ static void *HTMLMetaElement_QI(HTMLDOMNode *iface, REFIID riid)
return
HTMLElement_QI
(
&
This
->
element
.
node
,
riid
);
}
static
void
HTMLMetaElement_destructor
(
HTMLDOMNode
*
iface
)
{
HTMLMetaElement
*
This
=
HTMLMetaElement_from_HTMLDOMNode
(
iface
);
HTMLElement_destructor
(
&
This
->
element
.
node
);
}
static
const
NodeImplVtbl
HTMLMetaElementImplVtbl
=
{
.
clsid
=
&
CLSID_HTMLMetaElement
,
.
qi
=
HTMLMetaElement_QI
,
.
destructor
=
HTML
Meta
Element_destructor
,
.
destructor
=
HTMLElement_destructor
,
.
cpc_entries
=
HTMLElement_cpc
,
.
clone
=
HTMLElement_clone
,
.
handle_event
=
HTMLElement_handle_event
,
...
...
@@ -713,17 +692,10 @@ static void *HTMLHeadElement_QI(HTMLDOMNode *iface, REFIID riid)
return
HTMLElement_QI
(
&
This
->
element
.
node
,
riid
);
}
static
void
HTMLHeadElement_destructor
(
HTMLDOMNode
*
iface
)
{
HTMLHeadElement
*
This
=
impl_from_HTMLDOMNode
(
iface
);
HTMLElement_destructor
(
&
This
->
element
.
node
);
}
static
const
NodeImplVtbl
HTMLHeadElementImplVtbl
=
{
.
clsid
=
&
CLSID_HTMLHeadElement
,
.
qi
=
HTMLHeadElement_QI
,
.
destructor
=
HTML
Head
Element_destructor
,
.
destructor
=
HTMLElement_destructor
,
.
cpc_entries
=
HTMLElement_cpc
,
.
clone
=
HTMLElement_clone
,
.
handle_event
=
HTMLElement_handle_event
,
...
...
dlls/mshtml/htmlobject.c
View file @
912f1a43
...
...
@@ -1006,17 +1006,10 @@ static void *HTMLEmbedElement_QI(HTMLDOMNode *iface, REFIID riid)
return
HTMLElement_QI
(
&
This
->
element
.
node
,
riid
);
}
static
void
HTMLEmbedElement_destructor
(
HTMLDOMNode
*
iface
)
{
HTMLEmbed
*
This
=
embed_from_HTMLDOMNode
(
iface
);
HTMLElement_destructor
(
&
This
->
element
.
node
);
}
static
const
NodeImplVtbl
HTMLEmbedElementImplVtbl
=
{
.
clsid
=
&
CLSID_HTMLEmbed
,
.
qi
=
HTMLEmbedElement_QI
,
.
destructor
=
HTMLE
mbedE
lement_destructor
,
.
destructor
=
HTMLElement_destructor
,
.
cpc_entries
=
HTMLElement_cpc
,
.
clone
=
HTMLElement_clone
,
.
handle_event
=
HTMLElement_handle_event
,
...
...
dlls/mshtml/htmltable.c
View file @
912f1a43
...
...
@@ -446,13 +446,6 @@ static inline HTMLTableCell *HTMLTableCell_from_HTMLDOMNode(HTMLDOMNode *iface)
return
CONTAINING_RECORD
(
iface
,
HTMLTableCell
,
element
.
node
);
}
static
void
HTMLTableCell_destructor
(
HTMLDOMNode
*
iface
)
{
HTMLTableCell
*
This
=
HTMLTableCell_from_HTMLDOMNode
(
iface
);
HTMLElement_destructor
(
&
This
->
element
.
node
);
}
static
inline
HTMLTableCell
*
HTMLTableCell_from_DispatchEx
(
DispatchEx
*
iface
)
{
return
CONTAINING_RECORD
(
iface
,
HTMLTableCell
,
element
.
node
.
event_target
.
dispex
);
...
...
@@ -491,7 +484,7 @@ static void HTMLTableCell_unlink(DispatchEx *dispex)
static
const
NodeImplVtbl
HTMLTableCellImplVtbl
=
{
.
clsid
=
&
CLSID_HTMLTableCell
,
.
qi
=
HTMLTableCell_QI
,
.
destructor
=
HTML
TableCell
_destructor
,
.
destructor
=
HTML
Element
_destructor
,
.
cpc_entries
=
HTMLElement_cpc
,
.
clone
=
HTMLElement_clone
,
.
handle_event
=
HTMLElement_handle_event
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment