msxml3: Fix a memory leak (Valgrind).

Signed-off-by: Yongjie Yao <yaoyongjie@uniontech.com> Signed-off-by: Myah Caron <qsniyg@protonmail.com> Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msxml3: Fix a memory leak (Valgrind).
9336ec8f · Yongjie Yao · Alexandre Julliard · db1403c5 · 9336ec8f
Commit 9336ec8f authored Sep 11, 2020 by Yongjie Yao Committed by Alexandre Julliard Sep 14, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

domdoc.c dlls/msxml3/domdoc.c +4 -0

No files found.
--- a/dlls/msxml3/domdoc.c
+++ b/dlls/msxml3/domdoc.c
@@ -797,13 +797,17 @@ static HRESULT domdoc_load_from_stream(domdoc *doc, ISequentialStream *stream)

    hr = GetHGlobalFromStream(hstream, &hglobal);
    if (FAILED(hr))
+    {
+        IStream_Release(hstream);
        return hr;
+    }

    len = GlobalSize(hglobal);
    ptr = GlobalLock(hglobal);
    if (len)
        xmldoc = doparse(doc, ptr, len, XML_CHAR_ENCODING_NONE);
    GlobalUnlock(hglobal);
+    IStream_Release(hstream);

    if (!xmldoc)
    {