winemac: Only call -[NSApplication unhide:] if the app is actually hidden.

This avoids a Cocoa bug where, if an app in the background which is not hidden calls -unhide:, its main menu bar window is brought forward. The active app hasn't actually been changed. Key events continue to go to the app in the foreground. But it's confusing to the user when they look at the menu bar and, if they click in the menu bar, the background app really will be activated. Signed-off-by: Ken Thomases <ken@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

winemac: Only call -[NSApplication unhide:] if the app is actually hidden.
951a6c03 · Ken Thomases · Alexandre Julliard · a70c24d4 · 951a6c03
Commit 951a6c03 authored Jul 20, 2016 by Ken Thomases Committed by Alexandre Julliard Jul 21, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

cocoa_window.m dlls/winemac.drv/cocoa_window.m +2 -1

No files found.
--- a/dlls/winemac.drv/cocoa_window.m
+++ b/dlls/winemac.drv/cocoa_window.m
@@ -1427,7 +1427,8 @@ static CVReturn WineDisplayLinkCallback(CVDisplayLinkRef displayLink, const CVTi
            BOOL wasVisible;

            [controller transformProcessToForeground];
-            [NSApp unhide:nil];
+            if ([NSApp isHidden])
+                [NSApp unhide:nil];
            wasVisible = [self isVisible];

            if (activate)