usp10: Avoid leaking "open_stack" and "stack_index" in case of 0 "pair_count" in…

usp10: Avoid leaking "open_stack" and "stack_index" in case of 0 "pair_count" in computeBracketPairs(). Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com> Signed-off-by: Aric Stewart <aric@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

usp10: Avoid leaking "open_stack" and "stack_index" in case of 0 "pair_count" in…
99e61cee · Henri Verbeet · Alexandre Julliard · 77c74752 · 99e61cee
Commit 99e61cee authored Feb 18, 2018 by Henri Verbeet Committed by Alexandre Julliard Feb 19, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

bidi.c dlls/usp10/bidi.c +4 -2

No files found.
--- a/dlls/usp10/bidi.c
+++ b/dlls/usp10/bidi.c
@@ -741,6 +741,10 @@ static BracketPair *computeBracketPairs(IsolatedRun *iso_run)
            }
        }
    }
+
+    heap_free(open_stack);
+    heap_free(stack_index);
+
    if (pair_count == 0)
    {
        heap_free(out);
@@ -749,8 +753,6 @@ static BracketPair *computeBracketPairs(IsolatedRun *iso_run)
    else if (pair_count > 1)
        qsort(out, pair_count, sizeof(BracketPair), compr);

-    heap_free(open_stack);
-    heap_free(stack_index);
    return out;
 }