mshtml: Fix reference leak in HTMLStyleSheetRulesCollection_item.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com> Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mshtml: Fix reference leak in HTMLStyleSheetRulesCollection_item.
9ca56d3e · Gabriel Ivăncescu · Alexandre Julliard · c6b9cb77 · 9ca56d3e
Commit 9ca56d3e authored Oct 25, 2021 by Gabriel Ivăncescu Committed by Alexandre Julliard Nov 01, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

htmlstylesheet.c dlls/mshtml/htmlstylesheet.c +4 -1

No files found.
--- a/dlls/mshtml/htmlstylesheet.c
+++ b/dlls/mshtml/htmlstylesheet.c
@@ -348,6 +348,7 @@ static HRESULT WINAPI HTMLStyleSheetRulesCollection_item(IHTMLStyleSheetRulesCol
    HTMLStyleSheetRulesCollection *This = impl_from_IHTMLStyleSheetRulesCollection(iface);
    nsIDOMCSSRule *nsstylesheetrule;
    nsresult nsres;
+    HRESULT hres;

    TRACE("(%p)->(%d %p)\n", This, index, p);

@@ -357,7 +358,9 @@ static HRESULT WINAPI HTMLStyleSheetRulesCollection_item(IHTMLStyleSheetRulesCol
    if(!nsstylesheetrule)
        return E_INVALIDARG;

-    return create_style_sheet_rule(nsstylesheetrule, dispex_compat_mode(&This->dispex), p);
+    hres = create_style_sheet_rule(nsstylesheetrule, dispex_compat_mode(&This->dispex), p);
+    nsIDOMCSSRule_Release(nsstylesheetrule);
+    return hres;
 }

 static const IHTMLStyleSheetRulesCollectionVtbl HTMLStyleSheetRulesCollectionVtbl = {