windowscodecs: Avoid writing to the output pointer on failure in…

windowscodecs: Avoid writing to the output pointer on failure in StreamOnStreamRange::Read and StreamOnStreamRange::Write.

windowscodecs: Avoid writing to the output pointer on failure in…
a0bc2bd9 · Andrew Nguyen · Alexandre Julliard · 70d67bec · a0bc2bd9 · a0bc2bd9
Commit a0bc2bd9 authored Jan 21, 2011 by Andrew Nguyen Committed by Alexandre Julliard Jan 21, 2011
Expand all Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

stream.c dlls/windowscodecs/stream.c +2 -2

stream.c dlls/windowscodecs/tests/stream.c +0 -0

No files found.
--- a/dlls/windowscodecs/stream.c
+++ b/dlls/windowscodecs/stream.c
@@ -371,7 +371,7 @@ static HRESULT WINAPI StreamOnStreamRange_Read(IStream *iface,
        This->pos.QuadPart += uBytesRead;
    LeaveCriticalSection(&This->lock);

-    if (pcbRead) *pcbRead = uBytesRead;
+    if (SUCCEEDED(hr) && pcbRead) *pcbRead = uBytesRead;

    return hr;
 }
@@ -414,7 +414,7 @@ static HRESULT WINAPI StreamOnStreamRange_Write(IStream *iface,
        This->pos.QuadPart += uBytesWritten;
    LeaveCriticalSection(&This->lock);

-    if (pcbWritten) *pcbWritten = uBytesWritten;
+    if (SUCCEEDED(hr) && pcbWritten) *pcbWritten = uBytesWritten;

    return hr;
 }

--- a/dlls/windowscodecs/tests/stream.c
+++ b/dlls/windowscodecs/tests/stream.c