advpack: Avoid using sessions uninitialized (Coverity).

a6e4c094 · Marcus Meissner · Alexandre Julliard · 3173f173 · a6e4c094
Commit a6e4c094 authored Jan 07, 2013 by Marcus Meissner Committed by Alexandre Julliard Jan 08, 2013
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

files.c dlls/advpack/files.c +2 -1

No files found.
--- a/dlls/advpack/files.c
+++ b/dlls/advpack/files.c
@@ -708,6 +708,8 @@ HRESULT WINAPI ExtractFilesA(LPCSTR CabName, LPCSTR ExpandDir, DWORD Flags,
    if (!hCabinet)
        return E_FAIL;

+    ZeroMemory(&session, sizeof(SESSION));
+
    pExtract = (void *)GetProcAddress(hCabinet, "Extract");
    if (!pExtract)
    {
@@ -715,7 +717,6 @@ HRESULT WINAPI ExtractFilesA(LPCSTR CabName, LPCSTR ExpandDir, DWORD Flags,
        goto done;
    }

-    ZeroMemory(&session, sizeof(SESSION));
    lstrcpyA(session.Destination, ExpandDir);

    if (FileList)