crypt32: NULL ptr could leak into function (Coverity).

aa16c89b · Marcus Meissner · Alexandre Julliard · cd028045 · aa16c89b
Commit aa16c89b authored Dec 31, 2010 by Marcus Meissner Committed by Alexandre Julliard Dec 31, 2010
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

encode.c dlls/crypt32/encode.c +6 -1

No files found.
--- a/dlls/crypt32/encode.c
+++ b/dlls/crypt32/encode.c
@@ -4628,8 +4628,13 @@ BOOL WINAPI CryptEncodeObjectEx(DWORD dwCertEncodingType, LPCSTR lpszStructType,
    }

    SetLastError(NOERROR);
-    if (dwFlags & CRYPT_ENCODE_ALLOC_FLAG && pvEncoded)
+    if (dwFlags & CRYPT_ENCODE_ALLOC_FLAG) {
+        if (!pvEncoded) {
+            SetLastError(ERROR_INVALID_PARAMETER);
+            return FALSE;
+        }
        *(BYTE **)pvEncoded = NULL;
+    }
    encodeFunc = CRYPT_GetBuiltinEncoder(dwCertEncodingType, lpszStructType);
    if (!encodeFunc)
    {