Commit aa58bcfe authored by Marcus Meissner's avatar Marcus Meissner Committed by Alexandre Julliard

krnl386.exe16: Do not truncate the strcmp result (Coverity).

parent 1f1686fd
...@@ -254,7 +254,14 @@ SEGPTR WINAPI KERNEL_AnsiLower16( SEGPTR strOrChar ) ...@@ -254,7 +254,14 @@ SEGPTR WINAPI KERNEL_AnsiLower16( SEGPTR strOrChar )
*/ */
INT16 WINAPI KERNEL_lstrcmp16( LPCSTR str1, LPCSTR str2 ) INT16 WINAPI KERNEL_lstrcmp16( LPCSTR str1, LPCSTR str2 )
{ {
return (INT16)strcmp( str1, str2 ); int ret = strcmp( str1, str2 );
/* Looks too complicated, but in optimized strcpy we might get
* a 32bit wide difference and would truncate it to 16 bit, so
* erroneously returning equality. */
if (ret < 0) return -1;
if (ret > 0) return 1;
return 0;
} }
/*********************************************************************** /***********************************************************************
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment