Commit ace95ca0 authored by Dimitrie O. Paun's avatar Dimitrie O. Paun Committed by Alexandre Julliard

Small cleanups on how to send in patches.

parent 62dcebaa
<chapter id="patches"> <chapter id="patches">
<title>Submitting Patches</title> <title>Submitting Patches</title>
<para>
Written by &name-albert-den-haan; <email>&email-albert-den-haan;</email>
</para>
<sect1 id="patch-format"> <sect1 id="patch-format">
<title>Patch Format</title> <title>Patch Format</title>
<para> <para>
Your patch should include: Patches are submitted via email to the Wine patches mailing list,
<email>wine-patches@winehq.org</email>. Your patch should include:
</para> </para>
<itemizedlist> <itemizedlist>
...@@ -20,42 +18,40 @@ ...@@ -20,42 +18,40 @@
<listitem> <listitem>
<para> <para>
A long (paragraph) description of what was wrong and what is now A long (paragraph) description of what was wrong and what is now
better (and now broken :). (recommended) better. (recommended)
</para> </para>
</listitem> </listitem>
<listitem> <listitem>
<para> <para>
Change Log: A short description of what was changed. A change log entry (short description of what was changed).
</para> </para>
</listitem> </listitem>
<listitem> <listitem>
<para> <para>
Your contact information ( Name/Handle and e-mail ) The patch in <command>diff -u</command> format
</para>
</listitem>
<listitem>
<para>
The patch in <command>diff -u</command> format (it happens...)
</para> </para>
</listitem> </listitem>
</itemizedlist> </itemizedlist>
<para> <para>
</para>
<para>
<command>cvs diff -u</command> works great for the common case <command>cvs diff -u</command> works great for the common case
where a file is edited. However, if you add or remove a file where a file is edited. However, if you add or remove a file
<command>cvs diff</command> will not report that correctly so <command>cvs diff</command> will not report that correctly so
make sure you explicitly take care of this rare case. make sure you explicitly take care of this rare case.
</para> </para>
<para> <para>
For additions: mention that you have some new files and For additions simply include them by appending the
include them by appending the
<command>diff -u /dev/null /my/new/file</command> output of them <command>diff -u /dev/null /my/new/file</command> output of them
to any <command>cvs diff -u</command> output you may have. to any <command>cvs diff -u</command> output you may have.
Alternatively, use <command>diff -Nu olddir/ newdir/</command> Alternatively, use <command>diff -Nu olddir/ newdir/</command>
in case of multiple new files to add. in case of multiple new files to add.
</para> </para>
<para> <para>
For removals, list the files. For removals, clearly list the files in the description of the patch.
</para> </para>
<para> <para>
Since wine is constantly changing due to development it is strongly Since wine is constantly changing due to development it is strongly
...@@ -182,7 +178,7 @@ code ...@@ -182,7 +178,7 @@ code
<para> <para>
<quote>The basic rules are: no attachments, no mime crap, no <quote>The basic rules are: no attachments, no mime crap, no
line wrapping, a single patch per mail. Basically if I can't line wrapping, a single patch per mail. Basically if I can't
do <Command>"cat raw_mail | patch -p0"</command> it's in the do <command>"cat raw_mail | patch -p0"</command> it's in the
wrong format.</quote> wrong format.</quote>
</para> </para>
</sect2> </sect2>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment