dmloader: Don't leak memory in the cache.

Signed-off-by: Michael Stefaniuc <mstefani@winehq.org> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dmloader: Don't leak memory in the cache.
ad0dbe3e · Michael Stefaniuc · Alexandre Julliard · 3531e50c · ad0dbe3e
Commit ad0dbe3e authored Jul 25, 2017 by Michael Stefaniuc Committed by Alexandre Julliard Jul 25, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

loader.c dlls/dmloader/loader.c +2 -2

No files found.
--- a/dlls/dmloader/loader.c
+++ b/dlls/dmloader/loader.c
@@ -172,9 +172,7 @@ static ULONG WINAPI IDirectMusicLoaderImpl_Release(IDirectMusicLoader8 *iface)
    if (!ref) {
        unsigned int i;

-        /* Firstly, release the cache */
        IDirectMusicLoader8_ClearCache(iface, &GUID_DirectMusicAllTypes);
-        /* FIXME: Release all allocated entries */
        for (i = 0; i < ARRAY_SIZE(classes); i++)
            HeapFree(GetProcessHeap(), 0, This->search_paths[i]);
        HeapFree(GetProcessHeap(), 0, This);
@@ -806,6 +804,8 @@ static HRESULT WINAPI IDirectMusicLoaderImpl_ClearCache(IDirectMusicLoader8 *ifa
            (obj->Desc.dwValidData & DMUS_OBJ_LOADED)) {
            /* basically, wrap to ReleaseObject for each object found */
            IDirectMusicLoader8_ReleaseObject(iface, obj->pObject);
+            list_remove(&obj->entry);
+            HeapFree(GetProcessHeap(), 0, obj);
        }
    }