Skip to content

W
wine-winehq
Commit b084d7a4 authored by Marcus Meissner's avatar Marcus Meissner Committed by Alexandre Julliard
Browse files
Options

kernel32/tests: Avoid leaving com handle open (Coverity).

parent 75511e35
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 2 deletions
dlls/kernel32/tests/comm.c
View file @ b084d7a4
...@@ -1036,7 +1036,7 @@ static void test_LoopbackCtsRts(void) ...@@ -1036,7 +1036,7 @@ static void test_LoopbackCtsRts(void)
if (dcb.fRtsControl == RTS_CONTROL_HANDSHAKE) if (dcb.fRtsControl == RTS_CONTROL_HANDSHAKE)
{ {
trace("RTS_CONTROL_HANDSHAKE is set, so don't manipulate RTS\n"); trace("RTS_CONTROL_HANDSHAKE is set, so don't manipulate RTS\n");
CloseHandle(hcom); CloseHandle(hcom);
return; return;
} }
ok(GetCommModemStatus(hcom, &defaultStat), "GetCommModemStatus failed\n"); ok(GetCommModemStatus(hcom, &defaultStat), "GetCommModemStatus failed\n");
...@@ -1180,6 +1180,7 @@ static void test_LoopbackDtrRing(void) ...@@ -1180,6 +1180,7 @@ static void test_LoopbackDtrRing(void)
if (dcb.fDtrControl == DTR_CONTROL_HANDSHAKE) if (dcb.fDtrControl == DTR_CONTROL_HANDSHAKE)
{ {
trace("DTR_CONTROL_HANDSHAKE is set, so don't manipulate DTR\n"); trace("DTR_CONTROL_HANDSHAKE is set, so don't manipulate DTR\n");
CloseHandle(hcom);
return; return;
} }
ok(GetCommModemStatus(hcom, &defaultStat), "GetCommModemStatus failed\n"); ok(GetCommModemStatus(hcom, &defaultStat), "GetCommModemStatus failed\n");
...@@ -1592,6 +1593,7 @@ static void test_WaitRing(void) ...@@ -1592,6 +1593,7 @@ static void test_WaitRing(void)
ok((ret = GetCommModemStatus(hcom, &defaultStat)), "GetCommModemStatus failed\n"); ok((ret = GetCommModemStatus(hcom, &defaultStat)), "GetCommModemStatus failed\n");
if (!ret) { if (!ret) {
skip("modem status failed -> skip.\n"); skip("modem status failed -> skip.\n");
CloseHandle(hcom);
return; return;
} }
if(defaultStat & MS_RING_ON) if(defaultStat & MS_RING_ON)
...@@ -1668,7 +1670,7 @@ static void test_WaitDcd(void) ...@@ -1668,7 +1670,7 @@ static void test_WaitDcd(void)
if (dcb.fDtrControl == DTR_CONTROL_DISABLE) if (dcb.fDtrControl == DTR_CONTROL_DISABLE)
{ {
trace("DTR_CONTROL_HANDSHAKE is set, so don't manipulate DTR\n"); trace("DTR_CONTROL_HANDSHAKE is set, so don't manipulate DTR\n");
CloseHandle(hcom); CloseHandle(hcom);
return; return;
} }
args[0]= TIMEOUT >>1; args[0]= TIMEOUT >>1;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment