rpcrt4: Don't call IUnknown_AddRef if there is no outer unknown in

StdProxy_Construct as it will just crash anyway.

rpcrt4: Don't call IUnknown_AddRef if there is no outer unknown in
b7bf68f4 · Robert Shearman · Alexandre Julliard · 21fb7ab6 · b7bf68f4
Commit b7bf68f4 authored Feb 07, 2006 by Robert Shearman Committed by Alexandre Julliard Feb 07, 2006
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

cproxy.c dlls/rpcrt4/cproxy.c +5 -1

No files found.
--- a/dlls/rpcrt4/cproxy.c
+++ b/dlls/rpcrt4/cproxy.c
@@ -188,7 +188,11 @@ HRESULT WINAPI StdProxy_Construct(REFIID riid,
  This->pChannel = NULL;
  *ppProxy = (LPRPCPROXYBUFFER)&This->lpVtbl;
  *ppvObj = &This->PVtbl;
-  IUnknown_AddRef((IUnknown *)*ppvObj);
+  /* if there is no outer unknown then the caller will control the lifetime
+   * of the proxy object through the proxy buffer, so no need to increment the
+   * ref count of the proxy object */
+  if (pUnkOuter)
+    IUnknown_AddRef((IUnknown *)*ppvObj);
  IPSFactoryBuffer_AddRef(pPSFactory);

  return S_OK;