Skip to content

W
wine-winehq
Commit baf86bd5 authored by James Hawkins's avatar James Hawkins Committed by Alexandre Julliard
Browse files
Options

msi: MsiCollectUserInfo cannot be called from a custom action (Coverity 565, 566).

parent cb958cd7
Hide whitespace changes
Inline Side-by-side
Showing with 8 additions and 0 deletions
dlls/msi/msi.c
View file @ baf86bd5
...@@ -2927,7 +2927,11 @@ UINT WINAPI MsiCollectUserInfoW(LPCWSTR szProduct) ...@@ -2927,7 +2927,11 @@ UINT WINAPI MsiCollectUserInfoW(LPCWSTR szProduct)
if (rc != ERROR_SUCCESS) if (rc != ERROR_SUCCESS)
return ERROR_INVALID_PARAMETER; return ERROR_INVALID_PARAMETER;
/* MsiCollectUserInfo cannot be called from a custom action. */
package = msihandle2msiinfo(handle, MSIHANDLETYPE_PACKAGE); package = msihandle2msiinfo(handle, MSIHANDLETYPE_PACKAGE);
if (!package)
return ERROR_CALL_NOT_IMPLEMENTED;
rc = ACTION_PerformUIAction(package, szFirstRun, -1); rc = ACTION_PerformUIAction(package, szFirstRun, -1);
msiobj_release( &package->hdr ); msiobj_release( &package->hdr );
...@@ -2949,7 +2953,11 @@ UINT WINAPI MsiCollectUserInfoA(LPCSTR szProduct) ...@@ -2949,7 +2953,11 @@ UINT WINAPI MsiCollectUserInfoA(LPCSTR szProduct)
if (rc != ERROR_SUCCESS) if (rc != ERROR_SUCCESS)
return ERROR_INVALID_PARAMETER; return ERROR_INVALID_PARAMETER;
/* MsiCollectUserInfo cannot be called from a custom action. */
package = msihandle2msiinfo(handle, MSIHANDLETYPE_PACKAGE); package = msihandle2msiinfo(handle, MSIHANDLETYPE_PACKAGE);
if (!package)
return ERROR_CALL_NOT_IMPLEMENTED;
rc = ACTION_PerformUIAction(package, szFirstRun, -1); rc = ACTION_PerformUIAction(package, szFirstRun, -1);
msiobj_release( &package->hdr ); msiobj_release( &package->hdr );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment