Commit bb40bebd authored by Hans Leidekker's avatar Hans Leidekker Committed by Alexandre Julliard

msi: Let the InstallFiles action determine which private assembly files to install.

parent 12135acb
...@@ -282,8 +282,11 @@ MSIASSEMBLY *load_assembly( MSIPACKAGE *package, MSICOMPONENT *comp ) ...@@ -282,8 +282,11 @@ MSIASSEMBLY *load_assembly( MSIPACKAGE *package, MSICOMPONENT *comp )
if (a->application) if (a->application)
{ {
FIXME("we should probably check the manifest file here\n"); /* We can't check the manifest here because the target path may still change.
a->installed = (msi_get_property_int( package->db, szInstalled, 0 ) != 0); So we assume that the assembly is not installed and lean on the InstallFiles
action to determine which files need to be installed.
*/
a->installed = FALSE;
} }
else else
{ {
......
...@@ -74,7 +74,7 @@ static msi_file_state calculate_install_state( MSIFILE *file ) ...@@ -74,7 +74,7 @@ static msi_file_state calculate_install_state( MSIFILE *file )
TRACE("file %s is not scheduled for install\n", debugstr_w(file->File)); TRACE("file %s is not scheduled for install\n", debugstr_w(file->File));
return msifs_skipped; return msifs_skipped;
} }
if ((comp->assembly && !comp->assembly->installed) || if ((comp->assembly && !comp->assembly->application && !comp->assembly->installed) ||
GetFileAttributesW( file->TargetPath ) == INVALID_FILE_ATTRIBUTES) GetFileAttributesW( file->TargetPath ) == INVALID_FILE_ATTRIBUTES)
{ {
TRACE("file %s is missing\n", debugstr_w(file->File)); TRACE("file %s is missing\n", debugstr_w(file->File));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment