server: Do not call async_terminate() when restarting an already terminated async.

At best this is a no-op. At worst this will emit an extra APC_ASYNC_IO where the termination (e.g. cancellation) should already have emitted one. Signed-off-by: Zebediah Figura <zfigura@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

server: Do not call async_terminate() when restarting an already terminated async.
be070154 · Zebediah Figura · Alexandre Julliard · e4a2bca4 · be070154
Commit be070154 authored Aug 31, 2021 by Zebediah Figura Committed by Alexandre Julliard Sep 01, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 6 deletions

async.c server/async.c +4 -6

No files found.
--- a/server/async.c
+++ b/server/async.c
@@ -387,13 +387,11 @@ void async_set_result( struct object *obj, unsigned int status, apc_param_t tota

    if (status == STATUS_PENDING)  /* restart it */
    {
-        status = async->status;
-        async->status = STATUS_PENDING;
-
-        if (status != STATUS_ALERTED)  /* it was terminated in the meantime */
-            async_terminate( async, status );
-        else
+        if (async->status == STATUS_ALERTED)
+        {
+            async->status = STATUS_PENDING;
            async_reselect( async );
+        }
    }
    else
    {