wmp: Return E_POINTER when p is NULL in return_bstr.

Signed-off-by: Gijs Vermeulen <gijsvrm@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wmp: Return E_POINTER when p is NULL in return_bstr.
bf3d719d · Gijs Vermeulen · Alexandre Julliard · 3b0e8197 · bf3d719d · bf3d719d
Commit bf3d719d authored Aug 01, 2019 by Gijs Vermeulen Committed by Alexandre Julliard Aug 01, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

media.c dlls/wmp/tests/media.c +0 -1

wmp_private.h dlls/wmp/wmp_private.h +1 -1

No files found.
--- a/dlls/wmp/tests/media.c
+++ b/dlls/wmp/tests/media.c
@@ -535,7 +535,6 @@ static void test_media_item(void)
    hr = IWMPPlayer4_newMedia(player, NULL, &media);
    ok(hr == S_OK, "Failed to create a media item, hr %#x.\n", hr);
    hr = IWMPMedia_get_name(media, NULL);
-todo_wine
    ok(hr == E_POINTER, "Unexpected hr %#x.\n", hr);
    hr = IWMPMedia_get_name(media, &str);
    ok(hr == S_OK, "Failed to get item name, hr %#x.\n", hr);

--- a/dlls/wmp/wmp_private.h
+++ b/dlls/wmp/wmp_private.h
@@ -135,7 +135,7 @@ static inline WCHAR *heap_strdupW(const WCHAR *str)
 static inline HRESULT return_bstr(const WCHAR *value, BSTR *p)
 {
    if(!p)
-        return E_INVALIDARG;
+        return E_POINTER;

    if(value) {
        *p = SysAllocString(value);