rpcrt4: Fix use after free in get_iface_info.

Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

rpcrt4: Fix use after free in get_iface_info.
bfab009e · Jacek Caban · Alexandre Julliard · be4b3459 · bfab009e
Commit bfab009e authored Mar 26, 2020 by Jacek Caban Committed by Alexandre Julliard Mar 26, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 9 deletions

ndr_typelib.c dlls/rpcrt4/ndr_typelib.c +9 -9

No files found.
--- a/dlls/rpcrt4/ndr_typelib.c
+++ b/dlls/rpcrt4/ndr_typelib.c
@@ -1276,18 +1276,18 @@ static HRESULT get_iface_info(ITypeInfo *typeinfo, WORD *funcs, WORD *parentfunc
    if (FAILED(hr))
        goto err;
    hr = ITypeInfo_GetRefTypeInfo(*real_typeinfo, reftype, &parentinfo);
-    if (SUCCEEDED(hr))
-    {
-        hr = ITypeInfo_GetTypeAttr(parentinfo, &typeattr);
-        ITypeInfo_Release(parentinfo);
-    }
    if (FAILED(hr))
        goto err;
-    *parentiid = typeattr->guid;
+    hr = ITypeInfo_GetTypeAttr(parentinfo, &typeattr);
-    ITypeInfo_ReleaseTypeAttr(parentinfo, typeattr);
+    if (SUCCEEDED(hr))
+    {
-    return S_OK;
+        *parentiid = typeattr->guid;
+        ITypeInfo_ReleaseTypeAttr(parentinfo, typeattr);
+    }
+    ITypeInfo_Release(parentinfo);
+    if (SUCCEEDED(hr))
+        return hr;
 err:
    ITypeInfo_Release(*real_typeinfo);