dsound: Primary buffer size change tests.

It looks like Windows doesn't change the primary buffer length when changing formats so make the tests fail now. This means the current ALSA implementation is broken when hardware acceleration is set to full and the primary buffer format is changed.

dsound: Primary buffer size change tests.
c82a63ba · Robert Reif · Alexandre Julliard · 03b8fca7 · c82a63ba · c82a63ba
Commit c82a63ba authored Jan 17, 2006 by Robert Reif Committed by Alexandre Julliard Jan 17, 2006
Hide whitespace changes
Inline Side-by-side

Showing with 17 additions and 21 deletions

ds3d.c dlls/dsound/tests/ds3d.c +9 -11

ds3d8.c dlls/dsound/tests/ds3d8.c +8 -10

No files found.
--- a/dlls/dsound/tests/ds3d.c
+++ b/dlls/dsound/tests/ds3d.c
@@ -410,20 +410,18 @@ void test_buffer(LPDIRECTSOUND dso, LPDIRECTSOUNDBUFFER *dsbo,
            trace("    new Caps: flags=0x%08lx size=%ld\n",new_dsbcaps.dwFlags,
                  new_dsbcaps.dwBufferBytes);
        }
-                                                                                
+
        /* Check for primary buffer size change */
-        if (new_dsbcaps.dwBufferBytes != dsbcaps.dwBufferBytes) {
-            trace("    buffer size changed after SetFormat() - "
-                  "previous size was %lu, current size is %lu\n",
-                  dsbcaps.dwBufferBytes, new_dsbcaps.dwBufferBytes);
-        }
+        ok(new_dsbcaps.dwBufferBytes == dsbcaps.dwBufferBytes,
+           "    buffer size changed after SetFormat() - "
+           "previous size was %lu, current size is %lu\n",
+           dsbcaps.dwBufferBytes, new_dsbcaps.dwBufferBytes);

        /* Check for primary buffer flags change */
-        if (new_dsbcaps.dwFlags != dsbcaps.dwFlags) {
-            trace("    flags changed after SetFormat() - "
-                  "previous flags were %08lx, current flags are %08lx\n",
-                  dsbcaps.dwFlags, new_dsbcaps.dwFlags);
-        }
+        ok(new_dsbcaps.dwFlags == dsbcaps.dwFlags,
+           "    flags changed after SetFormat() - "
+           "previous flags were %08lx, current flags are %08lx\n",
+           dsbcaps.dwFlags, new_dsbcaps.dwFlags);

        /* Set the CooperativeLevel back to normal */
        /* DSOUND: Setting DirectSound cooperative level to DSSCL_NORMAL */

--- a/dlls/dsound/tests/ds3d8.c
+++ b/dlls/dsound/tests/ds3d8.c
@@ -304,18 +304,16 @@ void test_buffer8(LPDIRECTSOUND8 dso, LPDIRECTSOUNDBUFFER * dsbo,
        }

        /* Check for primary buffer size change */
-        if (new_dsbcaps.dwBufferBytes != dsbcaps.dwBufferBytes) {
-            trace("    buffer size changed after SetFormat() - "
-                  "previous size was %lu, current size is %lu\n",
-                  dsbcaps.dwBufferBytes, new_dsbcaps.dwBufferBytes);
-        }
+        ok(new_dsbcaps.dwBufferBytes == dsbcaps.dwBufferBytes,
+           "    buffer size changed after SetFormat() - "
+           "previous size was %lu, current size is %lu\n",
+           dsbcaps.dwBufferBytes, new_dsbcaps.dwBufferBytes);

        /* Check for primary buffer flags change */
-        if (new_dsbcaps.dwFlags != dsbcaps.dwFlags) {
-            trace("    flags changed after SetFormat() - "
-                  "previous flags were %08lx, current flags are %08lx\n",
-                  dsbcaps.dwFlags, new_dsbcaps.dwFlags);
-        }
+        ok(new_dsbcaps.dwFlags == dsbcaps.dwFlags,
+           "    flags changed after SetFormat() - "
+           "previous flags were %08lx, current flags are %08lx\n",
+           dsbcaps.dwFlags, new_dsbcaps.dwFlags);

        /* Set the CooperativeLevel back to normal */
        /* DSOUND: Setting DirectSound cooperative level to DSSCL_NORMAL */