Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
c9d24bdc
Commit
c9d24bdc
authored
Sep 30, 2008
by
Rob Shearman
Committed by
Alexandre Julliard
Sep 30, 2008
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
avifil32: Fix treating the return values of mmio* functions as HRESULTs instead of MMRESULTs.
(Found by PreFast.)
parent
6357f9c0
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
16 additions
and
10 deletions
+16
-10
extrachunk.c
dlls/avifil32/extrachunk.c
+16
-10
No files found.
dlls/avifil32/extrachunk.c
View file @
c9d24bdc
...
...
@@ -145,7 +145,7 @@ HRESULT FindChunkAndKeepExtras(LPEXTRACHUNKS extra,HMMIO hmmio,MMCKINFO *lpck,
{
FOURCC
ckid
;
FOURCC
fccType
;
HRESULT
h
r
;
MMRESULT
mm
r
;
/* pre-conditions */
assert
(
extra
!=
NULL
);
...
...
@@ -171,12 +171,13 @@ HRESULT FindChunkAndKeepExtras(LPEXTRACHUNKS extra,HMMIO hmmio,MMCKINFO *lpck,
TRACE
(
": find ckid=0x%08X fccType=0x%08X
\n
"
,
ckid
,
fccType
);
for
(;;)
{
h
r
=
mmioDescend
(
hmmio
,
lpck
,
lpckParent
,
0
);
if
(
hr
!=
S_OK
)
{
mm
r
=
mmioDescend
(
hmmio
,
lpck
,
lpckParent
,
0
);
if
(
mmr
!=
MMSYSERR_NOERROR
)
{
/* No extra chunks in front of desired chunk? */
if
(
flags
==
0
&&
hr
==
MMIOERR_CHUNKNOTFOUND
)
hr
=
AVIERR_OK
;
return
hr
;
if
(
flags
==
0
&&
mmr
==
MMIOERR_CHUNKNOTFOUND
)
return
AVIERR_OK
;
else
return
AVIERR_FILEREAD
;
}
/* Have we found what we search for? */
...
...
@@ -187,10 +188,15 @@ HRESULT FindChunkAndKeepExtras(LPEXTRACHUNKS extra,HMMIO hmmio,MMCKINFO *lpck,
/* Skip padding chunks, the others put into the extrachunk-structure */
if
(
lpck
->
ckid
==
ckidAVIPADDING
||
lpck
->
ckid
==
mmioFOURCC
(
'p'
,
'a'
,
'd'
,
'd'
))
hr
=
mmioAscend
(
hmmio
,
lpck
,
0
);
{
mmr
=
mmioAscend
(
hmmio
,
lpck
,
0
);
if
(
mmr
!=
MMSYSERR_NOERROR
)
return
AVIERR_FILEREAD
;
}
else
hr
=
ReadChunkIntoExtra
(
extra
,
hmmio
,
lpck
);
if
(
FAILED
(
hr
))
return
hr
;
{
HRESULT
hr
=
ReadChunkIntoExtra
(
extra
,
hmmio
,
lpck
);
if
(
FAILED
(
hr
))
return
hr
;
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment