mf: Set cancellation object directly (Coverity).

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mf: Set cancellation object directly (Coverity).
cb3517a1 · Nikolay Sivov · Alexandre Julliard · b2885d14 · cb3517a1
Commit cb3517a1 authored Mar 30, 2020 by Nikolay Sivov Committed by Alexandre Julliard Mar 30, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

main.c dlls/mf/main.c +5 -2

No files found.
--- a/dlls/mf/main.c
+++ b/dlls/mf/main.c
@@ -760,17 +760,20 @@ static HRESULT WINAPI file_scheme_handler_BeginCreateObject(IMFSchemeHandler *if

    hr = MFCreateAsyncResult(&context->IUnknown_iface, &handler->IMFAsyncCallback_iface, (IUnknown *)caller, &item);
    IUnknown_Release(&context->IUnknown_iface);
-    IMFAsyncResult_Release(caller);
    if (SUCCEEDED(hr))
    {
        if (SUCCEEDED(hr = MFPutWorkItemEx(MFASYNC_CALLBACK_QUEUE_IO, item)))
        {
            if (cancel_cookie)
-                IMFAsyncResult_GetState(item, cancel_cookie);
+            {
+                *cancel_cookie = (IUnknown *)caller;
+                IUnknown_AddRef(*cancel_cookie);
+            }
        }

        IMFAsyncResult_Release(item);
    }
+    IMFAsyncResult_Release(caller);

    return hr;
 }