Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
cf1bbb3b
Commit
cf1bbb3b
authored
Oct 26, 2013
by
Marcus Meissner
Committed by
Alexandre Julliard
Oct 28, 2013
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
crypt32: Avoid NULL ptr dereferences before checks (Coverity).
parent
eeefed3d
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
3 deletions
+9
-3
ctl.c
dlls/crypt32/ctl.c
+3
-1
store.c
dlls/crypt32/store.c
+6
-2
No files found.
dlls/crypt32/ctl.c
View file @
cf1bbb3b
...
@@ -341,7 +341,7 @@ PCCTL_CONTEXT WINAPI CertFindCTLInStore(HCERTSTORE hCertStore,
...
@@ -341,7 +341,7 @@ PCCTL_CONTEXT WINAPI CertFindCTLInStore(HCERTSTORE hCertStore,
BOOL
WINAPI
CertDeleteCTLFromStore
(
PCCTL_CONTEXT
pCtlContext
)
BOOL
WINAPI
CertDeleteCTLFromStore
(
PCCTL_CONTEXT
pCtlContext
)
{
{
WINECRYPT_CERTSTORE
*
hcs
=
pCtlContext
->
hCertStore
;
WINECRYPT_CERTSTORE
*
hcs
;
ctl_t
*
ctl
=
ctl_from_ptr
(
pCtlContext
);
ctl_t
*
ctl
=
ctl_from_ptr
(
pCtlContext
);
BOOL
ret
;
BOOL
ret
;
...
@@ -350,6 +350,8 @@ BOOL WINAPI CertDeleteCTLFromStore(PCCTL_CONTEXT pCtlContext)
...
@@ -350,6 +350,8 @@ BOOL WINAPI CertDeleteCTLFromStore(PCCTL_CONTEXT pCtlContext)
if
(
!
pCtlContext
)
if
(
!
pCtlContext
)
return
TRUE
;
return
TRUE
;
hcs
=
pCtlContext
->
hCertStore
;
if
(
hcs
->
dwMagic
!=
WINE_CRYPTCERTSTORE_MAGIC
)
if
(
hcs
->
dwMagic
!=
WINE_CRYPTCERTSTORE_MAGIC
)
return
FALSE
;
return
FALSE
;
...
...
dlls/crypt32/store.c
View file @
cf1bbb3b
...
@@ -949,13 +949,15 @@ PCCERT_CONTEXT WINAPI CertEnumCertificatesInStore(HCERTSTORE hCertStore, PCCERT_
...
@@ -949,13 +949,15 @@ PCCERT_CONTEXT WINAPI CertEnumCertificatesInStore(HCERTSTORE hCertStore, PCCERT_
BOOL
WINAPI
CertDeleteCertificateFromStore
(
PCCERT_CONTEXT
pCertContext
)
BOOL
WINAPI
CertDeleteCertificateFromStore
(
PCCERT_CONTEXT
pCertContext
)
{
{
WINECRYPT_CERTSTORE
*
hcs
=
pCertContext
->
hCertStore
;
WINECRYPT_CERTSTORE
*
hcs
;
TRACE
(
"(%p)
\n
"
,
pCertContext
);
TRACE
(
"(%p)
\n
"
,
pCertContext
);
if
(
!
pCertContext
)
if
(
!
pCertContext
)
return
TRUE
;
return
TRUE
;
hcs
=
pCertContext
->
hCertStore
;
if
(
hcs
->
dwMagic
!=
WINE_CRYPTCERTSTORE_MAGIC
)
if
(
hcs
->
dwMagic
!=
WINE_CRYPTCERTSTORE_MAGIC
)
return
FALSE
;
return
FALSE
;
...
@@ -1084,7 +1086,7 @@ BOOL WINAPI CertAddCRLContextToStore(HCERTSTORE hCertStore,
...
@@ -1084,7 +1086,7 @@ BOOL WINAPI CertAddCRLContextToStore(HCERTSTORE hCertStore,
BOOL
WINAPI
CertDeleteCRLFromStore
(
PCCRL_CONTEXT
pCrlContext
)
BOOL
WINAPI
CertDeleteCRLFromStore
(
PCCRL_CONTEXT
pCrlContext
)
{
{
WINECRYPT_CERTSTORE
*
hcs
=
pCrlContext
->
hCertStore
;
WINECRYPT_CERTSTORE
*
hcs
;
BOOL
ret
;
BOOL
ret
;
TRACE
(
"(%p)
\n
"
,
pCrlContext
);
TRACE
(
"(%p)
\n
"
,
pCrlContext
);
...
@@ -1092,6 +1094,8 @@ BOOL WINAPI CertDeleteCRLFromStore(PCCRL_CONTEXT pCrlContext)
...
@@ -1092,6 +1094,8 @@ BOOL WINAPI CertDeleteCRLFromStore(PCCRL_CONTEXT pCrlContext)
if
(
!
pCrlContext
)
if
(
!
pCrlContext
)
return
TRUE
;
return
TRUE
;
hcs
=
pCrlContext
->
hCertStore
;
if
(
hcs
->
dwMagic
!=
WINE_CRYPTCERTSTORE_MAGIC
)
if
(
hcs
->
dwMagic
!=
WINE_CRYPTCERTSTORE_MAGIC
)
return
FALSE
;
return
FALSE
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment