Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
dca24983
Commit
dca24983
authored
Nov 01, 2009
by
Jacek Caban
Committed by
Alexandre Julliard
Nov 03, 2009
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
mshtml: Return NULL ownerDocument for document node.
parent
82c8e7c6
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
22 additions
and
11 deletions
+22
-11
htmlnode.c
dlls/mshtml/htmlnode.c
+7
-2
dom.c
dlls/mshtml/tests/dom.c
+15
-9
No files found.
dlls/mshtml/htmlnode.c
View file @
dca24983
...
@@ -836,8 +836,13 @@ static HRESULT WINAPI HTMLDOMNode2_get_ownerDocument(IHTMLDOMNode2 *iface, IDisp
...
@@ -836,8 +836,13 @@ static HRESULT WINAPI HTMLDOMNode2_get_ownerDocument(IHTMLDOMNode2 *iface, IDisp
TRACE
(
"(%p)->(%p)
\n
"
,
This
,
p
);
TRACE
(
"(%p)->(%p)
\n
"
,
This
,
p
);
*
p
=
(
IDispatch
*
)
HTMLDOC
(
&
This
->
doc
->
basedoc
);
/* FIXME: Better check for document node */
IDispatch_AddRef
(
*
p
);
if
(
This
==
&
This
->
doc
->
node
)
{
*
p
=
NULL
;
}
else
{
*
p
=
(
IDispatch
*
)
HTMLDOC
(
&
This
->
doc
->
basedoc
);
IDispatch_AddRef
(
*
p
);
}
return
S_OK
;
return
S_OK
;
}
}
...
...
dlls/mshtml/tests/dom.c
View file @
dca24983
...
@@ -652,17 +652,18 @@ static IHTMLDocument2 *_get_owner_doc(unsigned line, IUnknown *unk)
...
@@ -652,17 +652,18 @@ static IHTMLDocument2 *_get_owner_doc(unsigned line, IUnknown *unk)
{
{
IHTMLDOMNode2
*
node
=
_get_node2_iface
(
line
,
unk
);
IHTMLDOMNode2
*
node
=
_get_node2_iface
(
line
,
unk
);
IDispatch
*
disp
=
(
void
*
)
0xdeadbeef
;
IDispatch
*
disp
=
(
void
*
)
0xdeadbeef
;
IHTMLDocument2
*
doc
;
IHTMLDocument2
*
doc
=
NULL
;
HRESULT
hres
;
HRESULT
hres
;
hres
=
IHTMLDOMNode2_get_ownerDocument
(
node
,
&
disp
);
hres
=
IHTMLDOMNode2_get_ownerDocument
(
node
,
&
disp
);
IHTMLDOMNode2_Release
(
node
);
IHTMLDOMNode2_Release
(
node
);
ok_
(
__FILE__
,
line
)(
hres
==
S_OK
,
"get_ownerDocument failed: %08x
\n
"
,
hres
);
ok_
(
__FILE__
,
line
)(
hres
==
S_OK
,
"get_ownerDocument failed: %08x
\n
"
,
hres
);
ok_
(
__FILE__
,
line
)(
disp
!=
NULL
,
"disp = NULL
\n
"
);
hres
=
IDispatch_QueryInterface
(
disp
,
&
IID_IHTMLDocument2
,
(
void
**
)
&
doc
);
if
(
disp
)
{
IDispatch_Release
(
disp
);
hres
=
IDispatch_QueryInterface
(
disp
,
&
IID_IHTMLDocument2
,
(
void
**
)
&
doc
);
ok_
(
__FILE__
,
line
)(
hres
==
S_OK
,
"Could not get IHTMLDocument2 iface: %08x
\n
"
,
hres
);
IDispatch_Release
(
disp
);
ok_
(
__FILE__
,
line
)(
hres
==
S_OK
,
"Could not get IHTMLDocument2 iface: %08x
\n
"
,
hres
);
}
return
doc
;
return
doc
;
}
}
...
@@ -940,8 +941,7 @@ static void test_get_set_attr(IHTMLDocument2 *doc)
...
@@ -940,8 +941,7 @@ static void test_get_set_attr(IHTMLDocument2 *doc)
hres
=
IHTMLElement_getAttribute
(
elem
,
bstr
,
0
,
&
val
);
hres
=
IHTMLElement_getAttribute
(
elem
,
bstr
,
0
,
&
val
);
ok
(
hres
==
S_OK
,
"getAttribute failed: %08x
\n
"
,
hres
);
ok
(
hres
==
S_OK
,
"getAttribute failed: %08x
\n
"
,
hres
);
ok
(
V_VT
(
&
val
)
==
VT_BOOL
,
"variant type should have been VT_BOOL (0x%x), was: 0x%x
\n
"
,
VT_BOOL
,
V_VT
(
&
val
));
ok
(
V_VT
(
&
val
)
==
VT_BOOL
,
"variant type should have been VT_BOOL (0x%x), was: 0x%x
\n
"
,
VT_BOOL
,
V_VT
(
&
val
));
ok
(
V_BOOL
(
&
val
)
==
VARIANT_TRUE
,
"variant value should have been VARIANT_TRUE (0x%x), was %d
\n
"
,
ok
(
V_BOOL
(
&
val
)
==
VARIANT_TRUE
,
"variant value should have been VARIANT_TRUE (0x%x), was %d
\n
"
,
VARIANT_TRUE
,
V_BOOL
(
&
val
));
VARIANT_TRUE
,
V_BOOL
(
&
val
));
VariantClear
(
&
val
);
VariantClear
(
&
val
);
SysFreeString
(
bstr
);
SysFreeString
(
bstr
);
...
@@ -4417,9 +4417,12 @@ static void test_doc_elem(IHTMLDocument2 *doc)
...
@@ -4417,9 +4417,12 @@ static void test_doc_elem(IHTMLDocument2 *doc)
doc_node
=
get_doc_node
(
doc
);
doc_node
=
get_doc_node
(
doc
);
owner_doc
=
get_owner_doc
((
IUnknown
*
)
elem
);
owner_doc
=
get_owner_doc
((
IUnknown
*
)
elem
);
ok
(
iface_cmp
((
IUnknown
*
)
doc_node
,
(
IUnknown
*
)
owner_doc
),
"doc_node != owner_doc
\n
"
);
ok
(
iface_cmp
((
IUnknown
*
)
doc_node
,
(
IUnknown
*
)
owner_doc
),
"doc_node != owner_doc
\n
"
);
IHTMLDocument2_Release
(
doc_node
);
IHTMLDocument2_Release
(
owner_doc
);
IHTMLDocument2_Release
(
owner_doc
);
owner_doc
=
get_owner_doc
((
IUnknown
*
)
doc_node
);
ok
(
!
owner_doc
,
"owner_doc = %p
\n
"
,
owner_doc
);
IHTMLDocument2_Release
(
doc_node
);
test_elem_client_rect
((
IUnknown
*
)
elem
);
test_elem_client_rect
((
IUnknown
*
)
elem
);
IHTMLElement_Release
(
elem
);
IHTMLElement_Release
(
elem
);
...
@@ -4781,8 +4784,8 @@ static void doc_write(IHTMLDocument2 *doc, BOOL ln, const char *text)
...
@@ -4781,8 +4784,8 @@ static void doc_write(IHTMLDocument2 *doc, BOOL ln, const char *text)
static
void
test_iframe_elem
(
IHTMLElement
*
elem
)
static
void
test_iframe_elem
(
IHTMLElement
*
elem
)
{
{
IHTMLDocument2
*
content_doc
,
*
owner_doc
;
IHTMLElementCollection
*
col
;
IHTMLElementCollection
*
col
;
IHTMLDocument2
*
content_doc
;
IHTMLWindow2
*
content_window
;
IHTMLWindow2
*
content_window
;
IHTMLFrameBase2
*
base2
;
IHTMLFrameBase2
*
base2
;
IDispatch
*
disp
;
IDispatch
*
disp
;
...
@@ -4837,6 +4840,9 @@ static void test_iframe_elem(IHTMLElement *elem)
...
@@ -4837,6 +4840,9 @@ static void test_iframe_elem(IHTMLElement *elem)
hres
=
IHTMLDocument2_close
(
content_doc
);
hres
=
IHTMLDocument2_close
(
content_doc
);
ok
(
hres
==
S_OK
,
"close failed: %08x
\n
"
,
hres
);
ok
(
hres
==
S_OK
,
"close failed: %08x
\n
"
,
hres
);
owner_doc
=
get_owner_doc
((
IUnknown
*
)
content_doc
);
ok
(
!
owner_doc
,
"owner_doc = %p
\n
"
,
owner_doc
);
IHTMLDocument2_Release
(
content_doc
);
IHTMLDocument2_Release
(
content_doc
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment