user32: Fix a potential buffer overflow.

Signed-off-by: Huw Davies <huw@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

user32: Fix a potential buffer overflow.
e0843d23 · Huw Davies · Alexandre Julliard · e725d9e3 · e0843d23
Commit e0843d23 authored Apr 21, 2017 by Huw Davies Committed by Alexandre Julliard Apr 21, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

sysparams.c dlls/user32/sysparams.c +1 -1

No files found.
--- a/dlls/user32/sysparams.c
+++ b/dlls/user32/sysparams.c
@@ -548,7 +548,7 @@ static DWORD load_entry( struct sysparam_entry *entry, void *data, DWORD size )
        if (RegQueryValueExW( base_key, entry->regval + 1, NULL, &type, data, &count )) count = 0;
    }
    /* make sure strings are null-terminated */
-    if (size && count == size && type == REG_SZ) ((WCHAR *)data)[count - 1] = 0;
+    if (size && count == size && type == REG_SZ) ((WCHAR *)data)[count / sizeof(WCHAR) - 1] = 0;
    entry->loaded = TRUE;
    return count;
 }