quartz: Avoid accessing the advise_sink structure after it is queued.

It could already have been removed and freed. Signed-off-by: Zebediah Figura <zfigura@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

quartz: Avoid accessing the advise_sink structure after it is queued.
e22e34ec · Zebediah Figura · Alexandre Julliard · bf5b35f1 · e22e34ec
Commit e22e34ec authored Oct 21, 2021 by Zebediah Figura Committed by Alexandre Julliard Oct 21, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

systemclock.c dlls/quartz/systemclock.c +1 -1

No files found.
--- a/dlls/quartz/systemclock.c
+++ b/dlls/quartz/systemclock.c
@@ -206,6 +206,7 @@ static HRESULT add_sink(struct system_clock *clock, DWORD_PTR handle,
    sink->due_time = due_time;
    sink->period = period;
    sink->cookie = InterlockedIncrement(&cookie_counter);
+    *cookie = sink->cookie;

    EnterCriticalSection(&clock->cs);
    list_add_tail(&clock->sinks, &sink->entry);
@@ -217,7 +218,6 @@ static HRESULT add_sink(struct system_clock *clock, DWORD_PTR handle,
    }
    WakeConditionVariable(&clock->cv);

-    *cookie = sink->cookie;
    return S_OK;
 }