Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
ec09119f
Commit
ec09119f
authored
Sep 16, 2018
by
Nikolay Sivov
Committed by
Alexandre Julliard
Sep 17, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
comctl32/button: Fix text buffer leak (Coverity).
Signed-off-by:
Nikolay Sivov
<
nsivov@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
06c5e950
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
1 deletion
+1
-1
button.c
dlls/comctl32/button.c
+1
-1
No files found.
dlls/comctl32/button.c
View file @
ec09119f
...
...
@@ -1293,7 +1293,6 @@ static UINT BUTTON_CalcLayoutRects(const BUTTON_INFO *infoPtr, HDC hdc, RECT *la
/* Get text rect */
maxTextWidth
=
labelRc
->
right
-
labelRc
->
left
;
textRect
=
BUTTON_GetTextRect
(
infoPtr
,
hdc
,
text
,
maxTextWidth
);
heap_free
(
text
);
/* Show image and text */
if
(
show_image_and_text
(
infoPtr
))
...
...
@@ -1361,6 +1360,7 @@ static UINT BUTTON_CalcLayoutRects(const BUTTON_INFO *infoPtr, HDC hdc, RECT *la
SetRectEmpty
(
&
imageRect
);
}
}
heap_free
(
text
);
CopyRect
(
labelRc
,
&
labelRect
);
CopyRect
(
imageRc
,
&
imageRect
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment