shell32: Don't increase refcount twice in SHGetImageList.

ed5a2992 · Owen Rudge · Alexandre Julliard · 19316ff8 · ed5a2992
Commit ed5a2992 authored Nov 18, 2009 by Owen Rudge Committed by Alexandre Julliard Nov 19, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 3 deletions

shellord.c dlls/shell32/shellord.c +1 -3

No files found.
--- a/dlls/shell32/shellord.c
+++ b/dlls/shell32/shellord.c
@@ -2203,9 +2203,7 @@ HRESULT WINAPI SHGetImageList(int iImageList, REFIID riid, void **ppv)
    if (hNew)
    {
        ret = HIMAGELIST_QueryInterface(hNew, riid, ppv);
+        ImageList_Destroy(hNew);
-        if (!SUCCEEDED(ret))
-            ImageList_Destroy(hNew);
    }
    return ret;