winegstreamer/media_source: Only seek if it was requested by the caller.

When starting a media source, the caller can specify a timestamp to seek to by mean of a PROPVARIANT argument. If the PROPVARIANT is empty, then no seek operation has to take place: playback has to either restart from the beginning (if the media source was previously in stopped state) or from where it was left (if the media source was in paused state). Also, when a PROPVARIANT is empty it is a bug to use its content, because there is no guarantee that it is initialized to a sensible value. This patch fixes both bugs by gating the seek operation with the check that the PROPVARIANT has the right type. Signed-off-by: Giovanni Mascellani <gmascellani@codeweavers.com> Signed-off-by: Huw Davies <huw@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

winegstreamer/media_source: Only seek if it was requested by the caller.
f45c8fd2 · Giovanni Mascellani · Alexandre Julliard · c9f0a3ce · f45c8fd2
Commit f45c8fd2 authored Sep 22, 2021 by Giovanni Mascellani Committed by Alexandre Julliard Sep 27, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

media_source.c dlls/winegstreamer/media_source.c +3 -2

No files found.
--- a/dlls/winegstreamer/media_source.c
+++ b/dlls/winegstreamer/media_source.c
@@ -329,8 +329,9 @@ static void start_pipeline(struct media_source *source, struct source_async_comm
    source->state = SOURCE_RUNNING;
-    unix_funcs->wg_parser_stream_seek(source->streams[0]->wg_stream, 1.0,
+    if (position->vt == VT_I8)
-            position->hVal.QuadPart, 0, AM_SEEKING_AbsolutePositioning, AM_SEEKING_NoPositioning);
+        unix_funcs->wg_parser_stream_seek(source->streams[0]->wg_stream, 1.0,
+                position->hVal.QuadPart, 0, AM_SEEKING_AbsolutePositioning, AM_SEEKING_NoPositioning);
    unix_funcs->wg_parser_end_flush(source->wg_parser);
 }