mfplat: Prevent use after free (Coverity).

Signed-off-by: Fabian Maurer <dark.shadow4@web.de> Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mfplat: Prevent use after free (Coverity).
f5d41f28 · Fabian Maurer · Alexandre Julliard · 312e0d51 · f5d41f28
Commit f5d41f28 authored Apr 26, 2022 by Fabian Maurer Committed by Alexandre Julliard Apr 27, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

mediatype.c dlls/mfplat/mediatype.c +2 -0

No files found.
--- a/dlls/mfplat/mediatype.c
+++ b/dlls/mfplat/mediatype.c
@@ -976,6 +976,7 @@ static const MFVIDEOFORMAT * WINAPI video_mediatype_GetVideoFormat(IMFVideoMedia
    TRACE("%p.\n", iface);

    CoTaskMemFree(media_type->video_format);
+    media_type->video_format = NULL;
    if (FAILED(hr = MFCreateMFVideoFormatFromMFMediaType(&media_type->IMFMediaType_iface, &media_type->video_format, &size)))
        WARN("Failed to create format description, hr %#lx.\n", hr);

@@ -1376,6 +1377,7 @@ static const WAVEFORMATEX * WINAPI audio_mediatype_GetAudioFormat(IMFAudioMediaT
    TRACE("%p.\n", iface);

    CoTaskMemFree(media_type->audio_format);
+    media_type->audio_format = NULL;
    if (FAILED(hr = MFCreateWaveFormatExFromMFMediaType(&media_type->IMFMediaType_iface, &media_type->audio_format,
            &size, MFWaveFormatExConvertFlag_Normal)))
    {