wininet: Fix an off-by-one error in the boundary checks in HTTP_DecodeBase64.

f8f9dbbb · Rob Shearman · Alexandre Julliard · eb0a8692 · f8f9dbbb
Commit f8f9dbbb authored Feb 15, 2008 by Rob Shearman Committed by Alexandre Julliard Feb 16, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

http.c dlls/wininet/http.c +2 -2

No files found.
--- a/dlls/wininet/http.c
+++ b/dlls/wininet/http.c
@@ -1129,9 +1129,9 @@ static UINT HTTP_DecodeBase64( LPCWSTR base64, LPSTR bin )
    {
        signed char in[4];

-        if (base64[0] > ARRAYSIZE(HTTP_Base64Dec) ||
+        if (base64[0] >= ARRAYSIZE(HTTP_Base64Dec) ||
            ((in[0] = HTTP_Base64Dec[base64[0]]) == -1) ||
-            base64[1] > ARRAYSIZE(HTTP_Base64Dec) ||
+            base64[1] >= ARRAYSIZE(HTTP_Base64Dec) ||
            ((in[1] = HTTP_Base64Dec[base64[1]]) == -1))
        {
            WARN("invalid base64: %s\n", debugstr_w(base64));