Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
f933dd8b
Commit
f933dd8b
authored
Dec 16, 2007
by
James Hawkins
Committed by
Alexandre Julliard
Dec 17, 2007
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msi: Validate the parameters of MsiOpenPackage.
parent
8fab39cc
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
5 deletions
+8
-5
package.c
dlls/msi/package.c
+7
-1
package.c
dlls/msi/tests/package.c
+1
-4
No files found.
dlls/msi/package.c
View file @
f933dd8b
...
...
@@ -932,9 +932,15 @@ UINT WINAPI MsiOpenPackageExW(LPCWSTR szPackage, DWORD dwOptions, MSIHANDLE *phP
TRACE
(
"%s %08x %p
\n
"
,
debugstr_w
(
szPackage
),
dwOptions
,
phPackage
);
if
(
szPackage
==
NULL
)
if
(
!
szPackage
||
!
phPackage
)
return
ERROR_INVALID_PARAMETER
;
if
(
!*
szPackage
)
{
FIXME
(
"Should create an empty database and package."
);
return
ERROR_FUNCTION_FAILED
;
}
if
(
dwOptions
)
FIXME
(
"dwOptions %08x not supported
\n
"
,
dwOptions
);
...
...
dlls/msi/tests/package.c
View file @
f933dd8b
...
...
@@ -2056,10 +2056,7 @@ static void test_msipackage(void)
/* NULL hProduct */
r
=
MsiOpenPackage
(
msifile
,
NULL
);
todo_wine
{
ok
(
r
==
ERROR_INVALID_PARAMETER
,
"Expected ERROR_INVALID_PARAMETER, got %d
\n
"
,
r
);
}
ok
(
r
==
ERROR_INVALID_PARAMETER
,
"Expected ERROR_INVALID_PARAMETER, got %d
\n
"
,
r
);
name
[
0
]
=
'#'
;
name
[
1
]
=
0
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment