mfreadwrite: Store result of object activation in stream transform.

In source_reader_create_transform(), store the result of IMFActivate_ActivateObject() so that in the event of failure, resources are freed and an appropriate HRESULT is returned. Previously, if every object's activation failed, the last part of the function was not aware of this.

mfreadwrite: Store result of object activation in stream transform.
f97e12de · Danyil Blyschak · Alexandre Julliard · 1dac9d7d · f97e12de
Commit f97e12de authored Apr 18, 2024 by Danyil Blyschak Committed by Alexandre Julliard Apr 23, 2024
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

reader.c dlls/mfreadwrite/reader.c +1 -1

No files found.
--- a/dlls/mfreadwrite/reader.c
+++ b/dlls/mfreadwrite/reader.c
@@ -2011,7 +2011,7 @@ static HRESULT source_reader_create_transform(struct source_reader *reader, BOOL
        {
            IMFMediaType *media_type;

-            if (FAILED(IMFActivate_ActivateObject(activates[i], &IID_IMFTransform, (void **)&transform)))
+            if (FAILED(hr = IMFActivate_ActivateObject(activates[i], &IID_IMFTransform, (void **)&transform)))
                continue;
            if (SUCCEEDED(hr = IMFTransform_SetInputType(transform, 0, input_type, 0))
                    && SUCCEEDED(hr = IMFTransform_GetInputCurrentType(transform, 0, &media_type)))